Bug 32858 - check-webkit-style should not warn about NULL usage in g_object_{get,set}
Summary: check-webkit-style should not warn about NULL usage in g_object_{get,set}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-22 01:12 PST by Philippe Normand
Modified: 2009-12-22 13:19 PST (History)
5 users (show)

See Also:


Attachments
proposed patch (2.43 KB, patch)
2009-12-22 01:41 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2009-12-22 01:12:37 PST
If those 2 functions are called with 0 instead of NULL the compiler warns:

warning: missing sentinel in function call
Comment 1 Philippe Normand 2009-12-22 01:41:20 PST
Created attachment 45375 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-22 01:43:18 PST
style-queue ran check-webkit-style on attachment 45375 [details] without any errors.
Comment 3 Adam Barth 2009-12-22 13:09:25 PST
Comment on attachment 45375 [details]
proposed patch

Thanks for quashing this false positive.
Comment 4 WebKit Commit Bot 2009-12-22 13:18:57 PST
Comment on attachment 45375 [details]
proposed patch

Clearing flags on attachment: 45375

Committed r52496: <http://trac.webkit.org/changeset/52496>
Comment 5 WebKit Commit Bot 2009-12-22 13:19:02 PST
All reviewed patches have been landed.  Closing bug.