Bug 38412 - Update MIPS JIT for unsigned right shift, Math.sqrt, load16
Summary: Update MIPS JIT for unsigned right shift, Math.sqrt, load16
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-30 16:13 PDT by Chao-ying Fu
Modified: 2010-05-15 01:59 PDT (History)
2 users (show)

See Also:


Attachments
MIPS JIT Update 20100430 (3.99 KB, patch)
2010-04-30 17:21 PDT, Chao-ying Fu
no flags Details | Formatted Diff | Diff
MIPS JIT Update 20100507 (4.98 KB, patch)
2010-05-07 17:07 PDT, Chao-ying Fu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chao-ying Fu 2010-04-30 16:13:17 PDT
After recent patches from https://bugs.webkit.org/show_bug.cgi?id=38294 and https://bugs.webkit.org/show_bug.cgi?id=38375, MIPS JIT needs to be updated.  I will upload a patch soon.  Thanks a lot!

Regards,
Chao-ying
Comment 1 Chao-ying Fu 2010-04-30 17:21:59 PDT
Created attachment 54839 [details]
MIPS JIT Update 20100430

Here is the patch.  Thanks!

Ex: (test results)
0 regressions found.
0 tests fixed.
OK.
Comment 2 Chao-ying Fu 2010-05-07 17:07:47 PDT
Created attachment 55436 [details]
MIPS JIT Update 20100507

Fixed MIPS build failures due to recent changes.
Thanks!

Regards,
Chao-ying
Comment 3 Chao-ying Fu 2010-05-11 17:20:45 PDT
From today's testing, I got two regressions.
        ecma_3/Date/15.9.5.4.js
        ecma_3/Function/regress-58274.js

2 regressions found.
0 tests fixed.

  The string access is not correct, if I access from the beginning a[0], a[1], a[2], ....

Ex 1:
# ./jsc
> a="01"
01
> a[0]
0
> a[1]
0 <--- THIS IS WRONG!
> a[2]
undefined

Ex 2:
# ./jsc
> a="01"
01
> a[2]
undefined
> a[1]
1 <--- THIS IS CORRECT!
> a[0]
0

  Can anyone help?  Maybe something is wrong in emitSlow_op_get_by_val.
Thanks a lot!

Regards,
Chao-ying
Comment 4 WebKit Commit Bot 2010-05-15 01:59:07 PDT
Comment on attachment 55436 [details]
MIPS JIT Update 20100507

Clearing flags on attachment: 55436

Committed r59527: <http://trac.webkit.org/changeset/59527>
Comment 5 WebKit Commit Bot 2010-05-15 01:59:12 PDT
All reviewed patches have been landed.  Closing bug.