Add fast paths for Math.pow and Math.sqrt
Created attachment 54640 [details] Patch
Attachment 54640 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/assembler/X86Assembler.h:1397: movsd_mr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/assembler/X86Assembler.h:1465: sqrtsd_rr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 54640 [details] Patch Have you tested USE(JSVALUE32)? – we shouldn't break this. One thought that might help a little on x86-64, you could plant these values:... > +static const double oneConstant = 1.0; > +static const double negativeHalfConstant = -0.5; ...somewhere in the JIT code buffers, then these could be loaded with a PC-relative memory access.
Committed r58469
http://trac.webkit.org/changeset/58469 might have broken Qt Linux Release
Fix landed in r58475.
https://bugs.webkit.org/show_bug.cgi?id=26987 Maybe we could revive this work as well. I have already tried to play around fast path for Math but they were rejected at that time.