Bug 37663 - Web Inspector: move JS VM specific code for collecting scope chain data into bindings
Summary: Web Inspector: move JS VM specific code for collecting scope chain data into ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on: 37740 37755
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-15 11:04 PDT by Yury Semikhatsky
Modified: 2010-05-11 05:12 PDT (History)
7 users (show)

See Also:

Attachments
patch (8.56 KB, patch)
2010-04-23 07:19 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-04-15 11:04:07 PDT 
Move JS VM specific code for collecting scope chain data into bindings. The scope chain representation is quite different in V8 in JSC and we need to encapsulate this specifics in the bindings layer so that same code in Web Inspector could iterate call frames in both VMs.
Comment 1 Yury Semikhatsky 2010-04-23 07:19:43 PDT 
Created attachment 54155 [details]
patch
Comment 2 Pavel Feldman 2010-04-23 07:56:19 PDT 
Comment on attachment 54155 [details]
patch

Please test this well manually prior to landing.
Comment 3 Yury Semikhatsky 2010-04-23 08:02:18 PDT 
Committed r58166