We need to move WebCore/inspector/JavaScriptCallFrame.{h,cpp} to the bindings layer to allow VM-specific implementations.
Created attachment 53586 [details] patch
Attachment 53586 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebCore/bindings/js/JavaScriptCallFrame.h:34: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/js/JavaScriptCallFrame.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] WARNING: Skipping non-existent file: WebCore/inspector/JavaScriptCallFrame.cpp WARNING: Skipping non-existent file: WebCore/inspector/JavaScriptCallFrame.h WebCore/bindings/js/JavaScriptCallFrame.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] WebCore/bindings/js/JavaScriptCallFrame.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 53586 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1658446
Comment on attachment 53586 [details] patch 1) Remove tab characters? 2) xproj file seems to be wrong r- for project file.
Created attachment 53600 [details] patch Addressed the comments.
Comment on attachment 53600 [details] patch Clearing flags on attachment: 53600 Committed r57784: <http://trac.webkit.org/changeset/57784>
All reviewed patches have been landed. Closing bug.