Bug 37740 - Web Inspector: move JavaScriptCallFrame to bindings
Summary: Web Inspector: move JavaScriptCallFrame to bindings
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
Depends on:
Blocks: 37663
  Show dependency treegraph
Reported: 2010-04-16 17:51 PDT by Yury Semikhatsky
Modified: 2010-04-17 11:42 PDT (History)
10 users (show)

See Also:

patch (24.67 KB, patch)
2010-04-16 17:55 PDT, Yury Semikhatsky
pfeldman: review-
Details | Formatted Diff | Diff
patch (22.56 KB, patch)
2010-04-17 11:25 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-04-16 17:51:16 PDT
We need to move WebCore/inspector/JavaScriptCallFrame.{h,cpp} to the bindings layer to allow VM-specific implementations.
Comment 1 Yury Semikhatsky 2010-04-16 17:55:06 PDT
Created attachment 53586 [details]
Comment 2 WebKit Review Bot 2010-04-16 17:59:03 PDT
Attachment 53586 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebCore/bindings/js/JavaScriptCallFrame.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/js/JavaScriptCallFrame.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: Skipping non-existent file: WebCore/inspector/JavaScriptCallFrame.cpp
WARNING: Skipping non-existent file: WebCore/inspector/JavaScriptCallFrame.h
WebCore/bindings/js/JavaScriptCallFrame.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
WebCore/bindings/js/JavaScriptCallFrame.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 5 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-04-16 18:01:04 PDT
Attachment 53586 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1658446
Comment 4 Pavel Feldman 2010-04-16 18:01:20 PDT
Comment on attachment 53586 [details]

1) Remove tab characters?
2) xproj file seems to be wrong

r- for project file.
Comment 5 Yury Semikhatsky 2010-04-17 11:25:07 PDT
Created attachment 53600 [details]

Addressed the comments.
Comment 6 WebKit Commit Bot 2010-04-17 11:42:17 PDT
Comment on attachment 53600 [details]

Clearing flags on attachment: 53600

Committed r57784: <http://trac.webkit.org/changeset/57784>
Comment 7 WebKit Commit Bot 2010-04-17 11:42:23 PDT
All reviewed patches have been landed.  Closing bug.