Bug 37755 – [v8] Web Inspector: implement JavaScriptCallFrame for v8

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Provide JavaScriptCallFrame implementation that works for v8.

[Yury Semikhatsky]

Created attachment 53608 [details]
patch

[Eric Seidel (no email)]

Attachment 53608 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1719123

[Adam Barth]

Comment on attachment 53608 [details]
patch

+ v8::Persistent<v8::Context> m_debuggerContext

Please use OwnHandle to avoid manual new/delete.

+ v8::Handle<v8::Value> callerFrame = m_callFrame->Get(v8String("caller"));

Is this value writeable from JavaScript?  Might we get confused about who the
caller is?

[Yury Semikhatsky]

Created attachment 53656 [details]
patch

[Yury Semikhatsky]

(In reply to comment #3)
> (From update of attachment 53608 [details])
> + v8::Persistent<v8::Context> m_debuggerContext
> 
> Please use OwnHandle to avoid manual new/delete.
> 
Done. Thanks for pointing that, I didn't know.

> + v8::Handle<v8::Value> callerFrame = m_callFrame->Get(v8String("caller"));
> 
> Is this value writeable from JavaScript?  Might we get confused about who the
> caller is?
This field is set in the debugger context from DebuggerScript.js when the call stack is traversed and only accessed from JavaScriptCallFrame.cpp

[Yury Semikhatsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gyp/WebCore.gyp
	M	WebCore/WebCore.gypi
	M	WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp
	A	WebCore/bindings/v8/JavaScriptCallFrame.cpp
	A	WebCore/bindings/v8/JavaScriptCallFrame.h
	M	WebCore/bindings/v8/ScriptDebugServer.cpp
	M	WebCore/bindings/v8/ScriptDebugServer.h
	M	WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
	A	WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp
	M	WebCore/inspector/JavaScriptCallFrame.idl
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebKit/chromium/src/js/DebuggerScript.js
Committed r57812

[WebKit Review Bot]

http://trac.webkit.org/changeset/57812 might have broken Chromium Linux Release