Bug 37755 - [v8] Web Inspector: implement JavaScriptCallFrame for v8
Summary: [v8] Web Inspector: implement JavaScriptCallFrame for v8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 37663
  Show dependency treegraph
 
Reported: 2010-04-17 12:51 PDT by Yury Semikhatsky
Modified: 2010-04-19 10:11 PDT (History)
10 users (show)

See Also:


Attachments
patch (21.43 KB, patch)
2010-04-17 13:03 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
patch (30.50 KB, patch)
2010-04-19 00:36 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-04-17 12:51:02 PDT
Provide JavaScriptCallFrame implementation that works for v8.
Comment 1 Yury Semikhatsky 2010-04-17 13:03:21 PDT
Created attachment 53608 [details]
patch
Comment 2 Eric Seidel (no email) 2010-04-17 13:08:36 PDT
Attachment 53608 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1719123
Comment 3 Adam Barth 2010-04-17 13:09:59 PDT
Comment on attachment 53608 [details]
patch

+ v8::Persistent<v8::Context> m_debuggerContext

Please use OwnHandle to avoid manual new/delete.

+ v8::Handle<v8::Value> callerFrame = m_callFrame->Get(v8String("caller"));

Is this value writeable from JavaScript?  Might we get confused about who the
caller is?
Comment 4 Yury Semikhatsky 2010-04-19 00:36:41 PDT
Created attachment 53656 [details]
patch
Comment 5 Yury Semikhatsky 2010-04-19 00:43:46 PDT
(In reply to comment #3)
> (From update of attachment 53608 [details])
> + v8::Persistent<v8::Context> m_debuggerContext
> 
> Please use OwnHandle to avoid manual new/delete.
> 
Done. Thanks for pointing that, I didn't know.

> + v8::Handle<v8::Value> callerFrame = m_callFrame->Get(v8String("caller"));
> 
> Is this value writeable from JavaScript?  Might we get confused about who the
> caller is?
This field is set in the debugger context from DebuggerScript.js when the call stack is traversed and only accessed from JavaScriptCallFrame.cpp
Comment 6 Yury Semikhatsky 2010-04-19 10:03:45 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gyp/WebCore.gyp
	M	WebCore/WebCore.gypi
	M	WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp
	A	WebCore/bindings/v8/JavaScriptCallFrame.cpp
	A	WebCore/bindings/v8/JavaScriptCallFrame.h
	M	WebCore/bindings/v8/ScriptDebugServer.cpp
	M	WebCore/bindings/v8/ScriptDebugServer.h
	M	WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
	A	WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp
	M	WebCore/inspector/JavaScriptCallFrame.idl
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebKit/chromium/src/js/DebuggerScript.js
Committed r57812
Comment 7 WebKit Review Bot 2010-04-19 10:11:19 PDT
http://trac.webkit.org/changeset/57812 might have broken Chromium Linux Release