Bug 3761 - Code Cleanup: Remove all uncessary #include statements from .h files
Summary: Code Cleanup: Remove all uncessary #include statements from .h files
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 412
Hardware: Macintosh OS X 10.4
: P3 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on: 4749 31964
Blocks: 40350 31965 31966
  Show dependency treegraph
 
Reported: 2005-06-29 00:56 PDT by Eric Seidel (no email)
Modified: 2011-04-25 14:11 PDT (History)
4 users (show)

See Also:


Attachments
please ignore (2.83 KB, text/plain)
2005-08-27 17:21 PDT, Arthur Langereis
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-06-29 00:56:25 PDT
Code Cleanup:  Remove all uncessary #include statements from .h files

Many, many, many kwq (and khtml) files have uncessary #include statements in the headers, which causes 
massive compile-time dependencies... meaning that a single change in kwq header basically amounts to 
rebuilding all of WebCore (due to the header cascade.

It would be really nice to see this cleaned up.  I will eventually get around to it if noone else does.. but in 
case new WebCore hackers are looking for something easy (and useful), this is such a bug.
Comment 1 Eric Seidel (no email) 2005-06-29 00:58:33 PDT
To be clear:

This means replacing things like:

#include <qstring.h>
with
class QString;
instead.

This is only possible when QString is neither returned from a function in the class, nor used as an 
instance variable on the class itself.
Comment 2 Arthur Langereis 2005-08-27 17:21:08 PDT
Created attachment 3611 [details]
please ignore

This is my proposed patch to add support for optional identifiers to function
expression statements. This is my first ever cvs patch, so please excuse any
mistakes.
Comment 3 Arthur Langereis 2005-08-27 17:24:20 PDT
Comment on attachment 3611 [details]
please ignore

Sorry, sorry, wrong bugreport! Never mind my comments
Comment 4 Jussi Hagman 2005-08-27 17:46:33 PDT
(In reply to comment #0)
> in  case new WebCore hackers are looking for something easy (and useful), this is such a bug.

This sounds like my kind of a job! Are there any issues or tips I should know before I start doing the 
cleanup? Is there any difference where I should start? Should I make one enormous patch or several small 
ones?
Comment 5 Maciej Stachowiak 2005-08-30 02:23:26 PDT
I think doing it incrementally is a good idea. I did some of the work in 4749
Comment 6 Eric Seidel (no email) 2011-04-25 10:44:25 PDT
I tried this again with bug 40350.  We should probably just dup these.