RESOLVED FIXED 211821
[IWYU] Try removing redundant includes in WTF implementation files 
https://bugs.webkit.org/show_bug.cgi?id=211821
Summary [IWYU] Try removing redundant includes in WTF implementation files
Ross Kirsling
Reported 2020-05-12 17:47:22 PDT
[IWYU] Try removing redundant includes in WTF implementation files
Attachments
Patch (32.75 KB, patch)
2020-05-12 17:47 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (32.23 KB, patch)
2020-05-12 17:58 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (31.70 KB, patch)
2020-05-12 18:07 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (32.31 KB, patch)
2020-05-12 18:20 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (31.88 KB, patch)
2020-05-12 18:39 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (31.58 KB, patch)
2020-05-12 18:56 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-05-12 17:47:49 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 2 2020-05-12 17:55:02 PDT
An initial experiment to see whether/how include-what-you-use could be of benefit to us. Procedure: - build non-unified JSCOnly on Mac - run `iwyu_tool.py ../../Source/WTF/wtf/ -p .` from build dir - manually examine recommended removals There are a slew of unfortunate things here... - for additions, they don't seem to like indirect dependencies, which seems to be in opposition to WK style - for removals, they want "config.h" removed from every file - I'm not sure if there's a way to prune includes from *headers*, which would be way more useful ...but there are still a lot of removals here so it's pretty neat if you have the patience?
Ross Kirsling
Comment 3 2020-05-12 17:58:39 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 4 2020-05-12 18:07:45 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 5 2020-05-12 18:20:20 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 6 2020-05-12 18:39:26 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 7 2020-05-12 18:56:47 PDT
Created attachment 399224 [details] Patch
EWS
Comment 8 2020-05-13 15:33:26 PDT
Committed r261661: <https://trac.webkit.org/changeset/261661> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399224 [details].
Radar WebKit Bug Importer
Comment 9 2020-05-13 15:34:18 PDT
<rdar://problem/63203335>
Note You need to log in before you can comment on or make changes to this bug.