Bug 211821 - [IWYU] Try removing redundant includes in WTF implementation files
Summary: [IWYU] Try removing redundant includes in WTF implementation files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-12 17:47 PDT by Ross Kirsling
Modified: 2020-05-13 15:34 PDT (History)
14 users (show)

See Also:

Attachments
Patch (32.75 KB, patch)
2020-05-12 17:47 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (32.23 KB, patch)
2020-05-12 17:58 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (31.70 KB, patch)
2020-05-12 18:07 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (32.31 KB, patch)
2020-05-12 18:20 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (31.88 KB, patch)
2020-05-12 18:39 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (31.58 KB, patch)
2020-05-12 18:56 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-05-12 17:47:22 PDT 
[IWYU] Try removing redundant includes in WTF implementation files
Comment 1 Ross Kirsling 2020-05-12 17:47:49 PDT Comment hidden (obsolete)
Comment 2 Ross Kirsling 2020-05-12 17:55:02 PDT 
An initial experiment to see whether/how include-what-you-use could be of benefit to us.

Procedure:
- build non-unified JSCOnly on Mac
- run `iwyu_tool.py ../../Source/WTF/wtf/ -p .` from build dir
- manually examine recommended removals

There are a slew of unfortunate things here...
- for additions, they don't seem to like indirect dependencies, which seems to be in opposition to WK style
- for removals, they want "config.h" removed from every file
- I'm not sure if there's a way to prune includes from *headers*, which would be way more useful

...but there are still a lot of removals here so it's pretty neat if you have the patience?
Comment 3 Ross Kirsling 2020-05-12 17:58:39 PDT Comment hidden (obsolete)
Comment 4 Ross Kirsling 2020-05-12 18:07:45 PDT Comment hidden (obsolete)
Comment 5 Ross Kirsling 2020-05-12 18:20:20 PDT Comment hidden (obsolete)
Comment 6 Ross Kirsling 2020-05-12 18:39:26 PDT Comment hidden (obsolete)
Comment 7 Ross Kirsling 2020-05-12 18:56:47 PDT 
Created attachment 399224 [details]
Patch
Comment 8 EWS 2020-05-13 15:33:26 PDT 
Committed r261661: <https://trac.webkit.org/changeset/261661>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399224 [details].
Comment 9 Radar WebKit Bug Importer 2020-05-13 15:34:18 PDT 
<rdar://problem/63203335>