I filed <https://bugs.webkit.org/show_bug.cgi?id=37014> using webkit-patch. I used: - webkit-prepare - webkit-upload When I uploaded the patch, I edited the changelog a bit (you can see it in the patch). The webkit-patch tool attached the patch to this bug instead: https://bugs.webkit.org/show_bug.cgi?id=36971
I'm not sure I know what webkit-prepare or webkit-upload are? Are those internal Apple scripts?
I expect he means: webkit-patch prepare webkit-patch upload
Correct. I used: webkit-patch prepare webkit-patch upload No Apple scripts.
*** Bug 37107 has been marked as a duplicate of this bug. ***
We've had several reports of this recently. We have a theory. Investigating now.
I've found a cause of this for SVN users. We have had a report from a Git user which I've not been able to reproduce yet. Fix coming shortly.
Created attachment 52940 [details] Patch
Comment on attachment 52940 [details] Patch Yay! Thanks for fixing this bug. + # FIXME: This should probably use cwd=self.checkout_root. We should use checkout_root in all these cases to make SCM more predictable and aligned between SVN and GIT.
Comment on attachment 52940 [details] Patch I agree. I'll file a bug about that.
Filed bug 37346 for followup.
Comment on attachment 52940 [details] Patch Clearing flags on attachment: 52940 Committed r57361: <http://trac.webkit.org/changeset/57361>
All reviewed patches have been landed. Closing bug.