37107 – webkit-patch post attached patch to the wrong bug.

Bug 37107 - webkit-patch post attached patch to the wrong bug.

Summary: webkit-patch post attached patch to the wrong bug.

Status:	RESOLVED DUPLICATE of bug 37015

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Mac (Intel) OS X 10.5

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-04-05 13:08 PDT by Eric U.
Modified:	2010-04-08 21:56 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric U. 2010-04-05 13:08:27 PDT

I created a small patch.
I used "webkit-patch prepare" to set up the one changelog entry; that stored the proper bug URL in the changelog.  I added my changelog text manually.
I then used "webkit-patch post" to post the patch, and it went to a bug I've never touched or done work on.  Here's the input+output of the terminal window in which this all happened.

I failed to notice that the bug number had been switched before typing in my credentials; I'll be on the lookout for that now.

[WebCore] ../WebKitTools/Scripts/webkit-patch preparePlease enter a bug number or a title for a new bug:
36671
  Running status to find changed, added, or removed files.
?      WebKitBuild
?      WebKit/chromium/WebKit.xcodeproj
?      WebKit/gtk/webkit/webkitwebview.cpp.orig
?      WebKit/mac/WebView/WebView.mm.orig
?      WebCore/storage/.DatabaseTracker.cpp.swp
  Reviewing diff to determine which lines changed.
?      WebCore/WebCore.gyp/idls_list_temp_file.tmp
?      WebKitTools/Scripts/webkitpy/steps
?      WebKitTools/Scripts/webkitpy/commands
?      WebKitTools/Scripts/webkitpy/python24/__init__.pyc
?      WebKitTools/Scripts/webkitpy/python24/versioning.pyc
?      WebKitTools/Scripts/webkitpy/common/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/changelog.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/commitinfo.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/api.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/scm.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/diff_parser.pyc
?      WebKitTools/Scripts/webkitpy/common/config/committers.pyc
?      WebKitTools/Scripts/webkitpy/common/config/ports.pyc
?      WebKitTools/Scripts/webkitpy/common/config/irc.pyc
?      WebKitTools/Scripts/webkitpy/common/config/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/net/credentials.pyc
?      WebKitTools/Scripts/webkitpy/common/net/networktransaction.pyc
?      WebKitTools/Scripts/webkitpy/common/net/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/net/buildbot.pyc
?      WebKitTools/Scripts/webkitpy/common/net/bugzilla.pyc
?      WebKitTools/Scripts/webkitpy/common/net/statusserver.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/messagepump.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/threadedmessagequeue.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/__init__.pyc
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.mechanize.url
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.pep8.py.url
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/clientform
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/__init__.py
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/irc
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/README
?      WebKitTools/Scripts/webkitpy/tool/bot/sheriff.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/sheriffircbot.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/__init__.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/queueengine.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/patchcollection.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/irc_command.pyc
  Extracting affected function names from source files.
  Change author: Eric Uhrhane <ericu@chromium.org>.
  Description from bug 36671:
    "window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5".
  Running 'svn update' to update ChangeLog files.
    U    WebCore/ChangeLog
    Updated to revision 57091.
  Editing the WebCore/ChangeLog file.
-- Please remember to include a detailed description in your ChangeLog entry. --
-- See <http://webkit.org/coding/contributing.html> for more info --
[WebCore] ../WebKitTools/Scripts/webkit-patch postParsing ChangeLog: /Users/ericu/four/src/third_party/WebKit/ChangeLog
Running check-webkit-style
?      WebKit/gtk/webkit/webkitwebview.cpp.orig
?      WebKit/mac/WebView/WebView.mm.orig
?      WebCore/.ChangeLog.swp
?      WebCore/WebCore.gyp/idls_list_temp_file.tmp
?      WebKitTools/Scripts/webkitpy/python24/__init__.pyc
?      WebKitTools/Scripts/webkitpy/python24/versioning.pyc
?      WebKitTools/Scripts/webkitpy/common/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/changelog.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/commitinfo.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/api.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/scm.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/diff_parser.pyc
?      WebKitTools/Scripts/webkitpy/common/config/committers.pyc
?      WebKitTools/Scripts/webkitpy/common/config/ports.pyc
?      WebKitTools/Scripts/webkitpy/common/config/irc.pyc
?      WebKitTools/Scripts/webkitpy/common/config/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/net/credentials.pyc
?      WebKitTools/Scripts/webkitpy/common/net/networktransaction.pyc
?      WebKitTools/Scripts/webkitpy/common/net/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/net/buildbot.pyc
?      WebKitTools/Scripts/webkitpy/common/net/bugzilla.pyc
?      WebKitTools/Scripts/webkitpy/common/net/statusserver.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/messagepump.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/threadedmessagequeue.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/__init__.pyc
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.mechanize.url
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.pep8.py.url
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/__init__.py
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/README
?      WebKitTools/Scripts/webkitpy/tool/bot/sheriff.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/sheriffircbot.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/__init__.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/queueengine.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/patchcollection.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/irc_command.pyc
Total errors found: 0 in 2 files
?      WebKit/gtk/webkit/webkitwebview.cpp.orig
?      WebKit/mac/WebView/WebView.mm.orig
?      WebCore/.ChangeLog.swp
?      WebCore/WebCore.gyp/idls_list_temp_file.tmp
?      WebKitTools/Scripts/webkitpy/python24/__init__.pyc
?      WebKitTools/Scripts/webkitpy/python24/versioning.pyc
?      WebKitTools/Scripts/webkitpy/common/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/changelog.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/commitinfo.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/api.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/scm.pyc
?      WebKitTools/Scripts/webkitpy/common/checkout/diff_parser.pyc
?      WebKitTools/Scripts/webkitpy/common/config/committers.pyc
?      WebKitTools/Scripts/webkitpy/common/config/ports.pyc
?      WebKitTools/Scripts/webkitpy/common/config/irc.pyc
?      WebKitTools/Scripts/webkitpy/common/config/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/net/credentials.pyc
?      WebKitTools/Scripts/webkitpy/common/net/networktransaction.pyc
?      WebKitTools/Scripts/webkitpy/common/net/__init__.pyc
?      WebKitTools/Scripts/webkitpy/common/net/buildbot.pyc
?      WebKitTools/Scripts/webkitpy/common/net/bugzilla.pyc
?      WebKitTools/Scripts/webkitpy/common/net/statusserver.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/messagepump.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/threadedmessagequeue.pyc
?      WebKitTools/Scripts/webkitpy/common/thread/__init__.pyc
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.mechanize.url
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.pep8.py.url
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/__init__.py
?      WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/README
?      WebKitTools/Scripts/webkitpy/tool/bot/sheriff.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/sheriffircbot.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/__init__.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/queueengine.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/patchcollection.pyc
?      WebKitTools/Scripts/webkitpy/tool/bot/irc_command.pyc
Was that diff correct? [Y/n]: 
Fetching: https://bugs.webkit.org/show_bug.cgi?id=36896&ctype=xml
Obsoleting 1 old patch on bug 36896
Reading Keychain for bugs.webkit.org account and password.  Click "Allow" to continue...
Could not find a keychain entry for bugs.webkit.org.
bugs.webkit.org login: ericu@chromium.org
bugs.webkit.org password for ericu@chromium.org: 
Logging in as ericu@chromium.org...
Obsoleting attachment: 52333
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=36896
[WebCore]

Comment 1 Eric U. 2010-04-07 16:40:19 PDT

It just hit dpranke as well, accidentally posting to the same bug.

Comment 2 Eric Seidel (no email) 2010-04-08 21:56:14 PDT

Duping against older bug.

*** This bug has been marked as a duplicate of bug 37015 ***