RESOLVED FIXED 36971
[Qt]Add -Wextra warning level to the QtWebKit build 
https://bugs.webkit.org/show_bug.cgi?id=36971
Summary [Qt]Add -Wextra warning level to the QtWebKit build
Laszlo Gombos
Reported 2010-04-01 10:37:57 PDT
QtWebKit should follow mac's lead to turn on -Wextra for QtWebKit build.
Attachments
proposed patch (1.32 KB, patch)
2010-04-01 10:49 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Patch (2.04 KB, patch)
2010-04-02 00:14 PDT, Steve Falkenburg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2010-04-01 10:47:46 PDT
I fully agree
Laszlo Gombos
Comment 2 2010-04-01 10:49:15 PDT
Created attachment 52312 [details] proposed patch New warnings introduced - I propose to address these in a separate patch as these warnings are not specific to the Qt port webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: In function 'bool pluginRemoveProperty(NPObject*, void*)': webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1005: warning: no return statement in function returning non-void webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: In function 'bool pluginEnumerate(NPObject*, void***, uint32_t*)': webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1009: warning: no return statement in function returning non-void webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: In function 'bool plugininConstruct(NPObject*, const NPVariant*, uint32_t, NPVariant*)': webkit/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:1013: warning: no return statement in function returning non-void
WebKit Commit Bot
Comment 3 2010-04-01 11:05:52 PDT
Comment on attachment 52312 [details] proposed patch Clearing flags on attachment: 52312 Committed r56923: <http://trac.webkit.org/changeset/56923>
WebKit Commit Bot
Comment 4 2010-04-01 11:05:59 PDT
All reviewed patches have been landed. Closing bug.
Steve Falkenburg
Comment 5 2010-04-02 00:14:25 PDT
Created attachment 52390 [details] Patch
Steve Falkenburg
Comment 6 2010-04-02 00:16:39 PDT
Ignore my patch in this bug - webkit-patch attached it to the wrong bug.
Eric Seidel (no email)
Comment 7 2010-04-02 00:22:25 PDT
Comment on attachment 52390 [details] Patch Sorry for the trouble steve! We believe to have fixed this in bug 36477 which was landed earlier today.
Eric Seidel (no email)
Comment 8 2010-04-02 00:22:50 PDT
Comment on attachment 52312 [details] proposed patch Leaving this un-marked. Laszlo can re-mark for review if needed.
Note You need to log in before you can comment on or make changes to this bug.