Bug 36186 - [Qt] Multiselect Popup - adjusting QtAbstractWebPopup
Summary: [Qt] Multiselect Popup - adjusting QtAbstractWebPopup
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on: 36178
Blocks: 36368
  Show dependency tree / graph
 
Reported: 2010-03-16 13:41 PDT by Luiz Agostini
Modified: 2010-03-25 03:05 PDT (History)
4 users (show)

See Also:

Attachments
patch 1 (2.99 KB, patch)
2010-03-16 14:02 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
patch 2 (3.15 KB, patch)
2010-03-19 11:41 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-03-16 13:41:51 PDT 
QtAbstractWebPopup must provide new methods to be used by its descendants that wish to handle <select multiple> elements.
Comment 1 Luiz Agostini 2010-03-16 14:02:32 PDT 
Created attachment 50834 [details]
patch 1
Comment 2 Luiz Agostini 2010-03-19 11:41:54 PDT 
Created attachment 51174 [details]
patch 2
Comment 3 Kenneth Rohde Christiansen 2010-03-19 21:35:34 PDT 
Comment on attachment 51174 [details]
patch 2

I assume this doesn't break normal non-multiple selects as valueChanged() is not never being called. Please confirm that before adding this to the cq.
Comment 4 Tor Arne Vestbø 2010-03-22 06:36:58 PDT 
Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs
Comment 5 Luiz Agostini 2010-03-22 10:15:15 PDT 
(In reply to comment #3)
> (From update of attachment 51174 [details])
> I assume this doesn't break normal non-multiple selects as valueChanged() is
> not never being called. Please confirm that before adding this to the cq.

It doesn't. :)
Comment 6 WebKit Commit Bot 2010-03-22 10:38:53 PDT 
Comment on attachment 51174 [details]
patch 2

Clearing flags on attachment: 51174

Committed r56341: <http://trac.webkit.org/changeset/56341>
Comment 7 WebKit Commit Bot 2010-03-22 10:38:58 PDT 
All reviewed patches have been landed.  Closing bug.