Bug 34675 - check-webkit-style: Move ProcessorOptions, ArgumentPrinter, and ArgumentParser classes into a separate file
Summary: check-webkit-style: Move ProcessorOptions, ArgumentPrinter, and ArgumentParse...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on: 34674
Blocks: 34677
  Show dependency treegraph
 
Reported: 2010-02-05 23:07 PST by Chris Jerdonek
Modified: 2010-02-18 21:17 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (60.06 KB, patch)
2010-02-18 14:12 PST, Chris Jerdonek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-02-05 23:07:36 PST
The new file can be called something like parser.py.
Comment 1 Chris Jerdonek 2010-02-06 14:08:24 PST
It makes more sense to split the class before moving, because then there will be less code to move, and there will be fewer dependencies to carry over in that initial move.
Comment 2 Chris Jerdonek 2010-02-18 14:12:43 PST
Created attachment 49041 [details]
Proposed patch

The additional unit tests I added were to cover development-testing errors that occurred when running "check-webkit-style" but that did not occur when running "test-webkitpy".
Comment 3 Shinichiro Hamaji 2010-02-18 18:59:58 PST
Comment on attachment 49041 [details]
Proposed patch

Looks good. Hmm... it was a bit difficult to check code move change with bugzilla. Eventually we may want to have better diff pretty printer.
Comment 4 WebKit Commit Bot 2010-02-18 21:17:10 PST
Comment on attachment 49041 [details]
Proposed patch

Clearing flags on attachment: 49041

Committed r55001: <http://trac.webkit.org/changeset/55001>
Comment 5 WebKit Commit Bot 2010-02-18 21:17:15 PST
All reviewed patches have been landed.  Closing bug.