Divide the ProcessorOptions class into a CheckWebKitStyleOptions class and a CheckerConfiguration class, per the FIXME's in checker.py.
Created attachment 48660 [details] Proposed patch Sorry for the length! This patch has no new functionality. The test coverage is pretty much the same.
> Sorry for the length! This patch has no new functionality. The test coverage > is pretty much the same. Looks OK, but I cannot be sure. Could you split this patch? Code cleanup done in this patch seems to be great (thanks!) but is somehow big. If possible, I'd like to review the refactoring work separately.
(In reply to comment #2) > > Sorry for the length! This patch has no new functionality. The test coverage > > is pretty much the same. > > Looks OK, but I cannot be sure. Could you split this patch? Code cleanup done > in this patch seems to be great (thanks!) but is somehow big. If possible, I'd > like to review the refactoring work separately. Sure, thanks. I'll do the clean-up here first: https://bugs.webkit.org/show_bug.cgi?id=34932
Comment on attachment 48660 [details] Proposed patch > Sure, thanks. I'll do the clean-up here first Thanks, It will help me a lot! Clearing r? flag to wait the cleanup effort.
Created attachment 48901 [details] Proposed patch 2
Comment on attachment 48901 [details] Proposed patch 2 Looks good!
Comment on attachment 48901 [details] Proposed patch 2 Rejecting patch 48901 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Shinichiro Hamaji', '--force']" exit_code: 1 Last 500 characters of output: bKitTools/Scripts/webkitpy/style/checker_unittest.py Hunk #10 FAILED at 514. Hunk #11 succeeded at 670 (offset 1 line). 1 out of 11 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/checker_unittest.py.rej patching file WebKitTools/Scripts/webkitpy/style/error_handlers.py patching file WebKitTools/Scripts/webkitpy/style/error_handlers_unittest.py patching file WebKitTools/Scripts/webkitpy/style/filter.py patching file WebKitTools/Scripts/webkitpy/style/filter_unittest.py Full output: http://webkit-commit-queue.appspot.com/results/282171
Manually committed after rebasing: http://trac.webkit.org/changeset/54934 (Commit-queue errors resulted from: https://bugs.webkit.org/show_bug.cgi?id=34971 )