Bug 34971 - check-webkit-style should report the number of files checked
Summary: check-webkit-style should report the number of files checked
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-02-16 03:01 PST by Shinichiro Hamaji
Modified: 2010-02-17 18:00 PST (History)
3 users (show)

See Also:

Patch v1 (3.67 KB, patch)
2010-02-16 03:01 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-02-16 03:01:04 PST
Currently, check-webkit-style reports

  Total errors found: 0

when the check succeeded. This message isn't good because this message also happens when no files are checked. For example, suppose there's a git commit and no unstaged changes. If you run check-webkit-style without options, no files will be checked. If you want to check the committed change, you need to specify --git-commit=HEAD .

Reporting the number of files checked by the style checker would help to avoid this kind of mistakes. With the patch I'll post, the style checker will report

  Total errors found: 0 in 0 files

We may be able to report more info, but this would be good as the start point.

I'm not sure if this change breaks WebKit buildbot (I guess it's OK because it checks the exit status code?). Adam and Eric, could you check it?
Comment 1 Shinichiro Hamaji 2010-02-16 03:01:59 PST
Created attachment 48799 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2010-02-17 16:38:09 PST
Comment on attachment 48799 [details]
Patch v1

Comment 3 Shinichiro Hamaji 2010-02-17 18:00:24 PST
Comment on attachment 48799 [details]
Patch v1

Clearing flags on attachment: 48799

Committed r54917: <http://trac.webkit.org/changeset/54917>
Comment 4 Shinichiro Hamaji 2010-02-17 18:00:32 PST
All reviewed patches have been landed.  Closing bug.