Bug 34677 - check-webkit-style: Eliminate support for "extra_flag_values" from ProcessorOptions, per the FIXME
Summary: check-webkit-style: Eliminate support for "extra_flag_values" from ProcessorO...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
Depends on: 34675
Blocks: 34676
  Show dependency treegraph
Reported: 2010-02-05 23:24 PST by Chris Jerdonek
Modified: 2010-03-09 00:32 PST (History)
5 users (show)

See Also:

Proposed patch (11.65 KB, patch)
2010-03-08 02:45 PST, Chris Jerdonek
hamaji: review+
cjerdonek: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-02-05 23:24:26 PST
It looks like support for extra_flag_values was added before check-webkit-style was forked (in order to support the "git-commit" option).  When the "git-commit" option was subsequently moved into ProcessorOptions, the extra_flag_values attribute became no longer necessary.
Comment 1 Chris Jerdonek 2010-03-08 02:45:14 PST
Created attachment 50199 [details]
Proposed patch
Comment 2 Shinichiro Hamaji 2010-03-08 21:56:51 PST
Comment on attachment 50199 [details]
Proposed patch

Comment 3 Chris Jerdonek 2010-03-09 00:32:45 PST
Manually committed: http://trac.webkit.org/changeset/55715