RESOLVED FIXED 34677
check-webkit-style: Eliminate support for "extra_flag_values" from ProcessorOptions, per the FIXME 
https://bugs.webkit.org/show_bug.cgi?id=34677
Summary check-webkit-style: Eliminate support for "extra_flag_values" from ProcessorO...
Chris Jerdonek
Reported 2010-02-05 23:24:26 PST
It looks like support for extra_flag_values was added before check-webkit-style was forked (in order to support the "git-commit" option). When the "git-commit" option was subsequently moved into ProcessorOptions, the extra_flag_values attribute became no longer necessary.
Attachments
Proposed patch (11.65 KB, patch)
2010-03-08 02:45 PST, Chris Jerdonek 		hamaji: review+
cjerdonek: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-03-08 02:45:14 PST
Created attachment 50199 [details] Proposed patch
Shinichiro Hamaji
Comment 2 2010-03-08 21:56:51 PST
Comment on attachment 50199 [details] Proposed patch Great!
Chris Jerdonek
Comment 3 2010-03-09 00:32:45 PST
Manually committed: http://trac.webkit.org/changeset/55715
Note You need to log in before you can comment on or make changes to this bug.