Bug 33917 - [Chromium] "ChromiumBridge" should be also accessible as "PlatformBridge"
Summary: [Chromium] "ChromiumBridge" should be also accessible as "PlatformBridge"
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 33608 33673
  Show dependency treegraph
Reported: 2010-01-20 12:55 PST by Andrei Popescu
Modified: 2010-01-21 11:01 PST (History)
2 users (show)

See Also:

Add PlatformBridge.h header. (3.10 KB, patch)
2010-01-20 13:15 PST, Andrei Popescu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Popescu 2010-01-20 12:55:56 PST
A better name for ChromiumBridge is PlatformBridge. This is because, on Chromium, it is the client that provides some of the functionality that is normally provided by the underlying operating system (or platform). This functionality is accessible via the ChromiumBridge class, so the word "Chromium" is used where "Platform" is actually meant.

Android already uses PlatformBridge in a similar way to how Chromium uses ChromiumBridge. Therefore, an added benefit of renaming ChromiumBridge to PlatformBridge is that the two ports, Android and Chromium, will share code without the need for any #ifdefs.

We therefore aim to rename ChromiumBridge to PlatformBridge. For now, we will add the PlatformBridge.h header and just typedef ChromiumBridge PlatformBridge. This is what this bug tracks. When the Android port is fully upstreamed, we will rename ChromiumBridge to PlatformBridge and merge it with Android's version. This will be tracked in a separate bug.

Patch coming soon.
Comment 1 Andrei Popescu 2010-01-20 13:15:55 PST
Created attachment 47056 [details]
Add PlatformBridge.h header.
Comment 2 WebKit Commit Bot 2010-01-21 11:01:36 PST
Comment on attachment 47056 [details]
Add PlatformBridge.h header.

Clearing flags on attachment: 47056

Committed r53633: <http://trac.webkit.org/changeset/53633>
Comment 3 WebKit Commit Bot 2010-01-21 11:01:41 PST
All reviewed patches have been landed.  Closing bug.