Bug 33608 – [Android] bindings/v8/NPV8Object.cpp does not compile on Android

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andrei Popescu]

bindings/v8/NPV8Object.cpp because

1. it includes "bindings/npruntime.h". This file is actually from the Chromium source tree in third_party/npapi/. On Android, we can live with the standard npruntime.h header in WebCore/bridge/. Ideally, Chromium would move their changes to bridge/npruntime.h and gave up using the non-standard header.
2. it uses ARRAYSIZE_UNSAFE macro, which is defined in the Chromium repository in base/basictypes.h. On Android, we will copy this macro into platform/android/PlatformBridge.h

Patch coming soon.

[Andrei Popescu]

Created attachment 46476 [details]
Fix bindings/v8/NPV8Object.cpp to compile on Android

[Eric Seidel (no email)]

Seems the ARRAYSIZE_UNSAFE macro should move into WTF at some point.  Ojan filed a bug about that a while back.  Not specifically about that macro, but about the idea of having a macro or template function to do C-style array size calculations.

[David Levin]

Comment on attachment 46476 [details]
Fix bindings/v8/NPV8Object.cpp to compile on Android

Pls get rid of ifdef's as discussed.

[Andrei Popescu]

I filed a separate bug (33917) for adding the PlatformBridge.h header. Will upload a new patch here, as well.

[Andrei Popescu]

Created attachment 47109 [details]
Fix bindings/v8/NPV8Object.cpp to compile on Android

[David Levin]

Comment on attachment 47109 [details]
Fix bindings/v8/NPV8Object.cpp to compile on Android

Just a few nits to address below and submit away.


> Index: WebCore/bindings/v8/NPV8Object.h

> +#if PLATFORM(CHROMIUM)
> +// Chromium uses a different npruntime.h, which is in
> +// the Chromium source repository under third_party/npapi/bindings.
> +// The Google-specific changes in that file should probably be

Should this say "FIXME: " right before it.

> +// moved into bridge/npruntime.h, guarded by an #if PlATFORM(CHROMIUM).
>  #include "bindings/npruntime.h"
> +#else
> +#include "bridge/npruntime.h"  // use WebCore version for Android and other ports.

Please capitalize the u (s/use/Use/) and only have a single space before end of line comments.


> Index: WebCore/platform/android/PlatformBridge.h

Add 2010 to the copyright line?

> +// ARRAYSIZE_UNSAFE performs essentially the same calculation as arraysize,
> +// but can be used on anonymous types or types defined inside
> +// functions.  It's less safe than arraysize as it accepts some

Only use single spaces after periods in comments for WebKit code.

> +// (although not all) pointers.  Therefore, you should use arraysize

Single space after period.

> +// ARRAYSIZE_UNSAFE catches a few type errors.  If you see a compiler error

Single space after period.


> +// the array) and sizeof(*(arr)) (the # of bytes in one array
> +// element).  If the former is divisible by the latter, perhaps arr is

Single space after period.

> +// indeed an array, in which case the division result is the # of
> +// elements in the array.  Otherwise, arr cannot possibly be an array,

Single space after period.

> +// and we generate a compiler error to prevent the code from
> +// compiling.


> +// pointers, namely where the pointer size is divisible by the pointee
> +// size.  Since all our code has to go through a 32-bit compiler,

Single space after period.

[Andrei Popescu]

Thanks for the review David. I addressed all your comments and Steve Block landed the patch in http://trac.webkit.org/changeset/53634