RESOLVED FIXED 33673
[Android] bindings/v8/ScriptController.cpp needs to conditionally include ChromiumBridge.h or PlatformBridge.h, depending on the platform (Chromium or Android) 
https://bugs.webkit.org/show_bug.cgi?id=33673
Summary [Android] bindings/v8/ScriptController.cpp needs to conditionally include Chr...
Andrei Popescu
Reported 2010-01-14 07:33:02 PST
bindings/v8/ScriptController.cpp needs to conditionally include ChromiumBridge.h or PlatformBridge.h, depending on the platform (Chromium or Android) Android's PlatformBridge class also needs the static NPObject* pluginScriptableObject(Widget*); method, which provides the NPObject associated with a PluginView.
Attachments
Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp (2.57 KB, patch)
2010-01-14 07:39 PST, Andrei Popescu 		no flags
DetailsFormatted DiffDiff
Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp (2.58 KB, patch)
2010-01-14 07:43 PST, Andrei Popescu 		levin: review-
DetailsFormatted DiffDiff
Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp (2.46 KB, patch)
2010-01-20 13:22 PST, Andrei Popescu 		no flags
DetailsFormatted DiffDiff
Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp (2.45 KB, patch)
2010-01-20 14:03 PST, Andrei Popescu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andrei Popescu
Comment 1 2010-01-14 07:39:59 PST
Created attachment 46565 [details] Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp
Andrei Popescu
Comment 2 2010-01-14 07:43:34 PST
Created attachment 46566 [details] Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp Had a tab in the Changelog in the previous patch.
David Levin
Comment 3 2010-01-20 08:08:17 PST
Comment on attachment 46566 [details] Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp Please remove ifdef's as discussed.
Andrei Popescu
Comment 4 2010-01-20 12:58:49 PST
I filed a separate bug (33917) about adding the "PlatformBridge.h" header. Will upload a new patch here as well.
Andrei Popescu
Comment 5 2010-01-20 13:22:37 PST
Created attachment 47057 [details] Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp
Andrei Popescu
Comment 6 2010-01-20 14:03:12 PST
Created attachment 47062 [details] Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp Forgot to update the Changelog to reflect the changes in the latest patch.
WebKit Commit Bot
Comment 7 2010-01-21 21:06:46 PST
Comment on attachment 47062 [details] Add PlatformBridge::pluginScriptableObject and include PlatformBridge.h from ScriptController.cpp Clearing flags on attachment: 47062 Committed r53673: <http://trac.webkit.org/changeset/53673>
WebKit Commit Bot
Comment 8 2010-01-21 21:06:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.