Bug 32915 - valueAsDate setter Part 2: ISODateTime -> String conversion
Summary: valueAsDate setter Part 2: ISODateTime -> String conversion
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.whatwg.org/specs/web-apps/...
Keywords:
Depends on: 32901
Blocks: 32697
  Show dependency tree / graph
 
Reported: 2009-12-23 21:31 PST by Kent Tamura
Modified: 2009-12-29 08:54 PST (History)
2 users (show)

See Also:

Attachments
Proposed patch (6.39 KB, patch)
2009-12-23 21:40 PST, Kent Tamura 		mjs: review-
tkent: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-12-23 21:31:37 PST 
In order to implement HTMLInputElement::setValueAsDate, we need to implement
 1. millisecond double value to ISODateTime conversion
 2. ISODateTime to String conversion

This bug handles the step 2 above.
Comment 1 Kent Tamura 2009-12-23 21:40:16 PST 
Created attachment 45462 [details]
Proposed patch

This patch depends on the patch in Bug#32901.
Comment 2 WebKit Review Bot 2009-12-23 21:44:04 PST 
Attachment 45462 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/143618
Comment 3 WebKit Review Bot 2009-12-23 21:45:13 PST 
style-queue ran check-webkit-style on attachment 45462 [details] without any errors.
Comment 4 Kent Tamura 2009-12-23 21:48:05 PST 
(In reply to comment #2)
> Attachment 45462 [details] did not build on chromium:
> Build output: http://webkit-commit-queue.appspot.com/results/143618

It's expected. This patch depends on a uncommitted patch.
Comment 5 WebKit Review Bot 2009-12-26 06:15:34 PST 
Attachment 45462 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/145780
Comment 6 Maciej Stachowiak 2009-12-28 02:12:59 PST 
Comment on attachment 45462 [details]
Proposed patch

This patch lacks tests. Perhaps it is only testable in combination with part 1, in which case I'd rather see the two combined into one patch with tests included.
Comment 7 Kent Tamura 2009-12-29 08:54:04 PST 
Deprecated by Bug#33021.