Bug 33021 - HTMLInputElement::valueAsDate setter support for type=month
Summary: HTMLInputElement::valueAsDate setter support for type=month
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 32697
  Show dependency treegraph
 
Reported: 2009-12-29 08:42 PST by Kent Tamura
Modified: 2010-01-18 17:50 PST (History)
3 users (show)

See Also:


Attachments
Proposed patch (18.04 KB, patch)
2009-12-29 08:51 PST, Kent Tamura
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-12-29 08:42:56 PST
Implement setValueAsDate() of HTMLInputElement class only for type=month.
Comment 1 Kent Tamura 2009-12-29 08:51:08 PST
Created attachment 45605 [details]
Proposed patch
Comment 2 WebKit Review Bot 2009-12-29 08:52:28 PST
style-queue ran check-webkit-style on attachment 45605 [details] without any errors.
Comment 3 Kent Tamura 2010-01-17 23:50:19 PST
Add Darin to Cc because he reviewd the getter part of HTMLInputElement::valueAsData.
Comment 4 Darin Adler 2010-01-18 12:23:41 PST
Comment on attachment 45605 [details]
Proposed patch

Looks fine.

I don't approve of the use of ` and ' to be the two sides of a quote. It should just be ' and ' on both sides.

r=me
Comment 5 Kent Tamura 2010-01-18 17:50:22 PST
> I don't approve of the use of ` and ' to be the two sides of a quote. It should
> just be ' and ' on both sides.

Correct all of `' pairs and committed as r53445.
Thanks!