Bug 32901 - valueAsDate setter Part 1: millisecond -> ISODateTime conversion
Summary: valueAsDate setter Part 1: millisecond -> ISODateTime conversion
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.whatwg.org/specs/web-apps/...
Keywords:
Depends on:
Blocks: 32697 32915
  Show dependency treegraph
 
Reported: 2009-12-23 08:08 PST by Kent Tamura
Modified: 2009-12-29 08:52 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (15.63 KB, patch)
2009-12-23 08:30 PST, Kent Tamura
mjs: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-12-23 08:08:29 PST
In order to implement HTMLInputElement::setValueAsDate, we need to implement
 1. millisecond double value to ISODateTime conversion
 2. ISODateTime to String conversion

This bug handles the step 1 above.
Comment 1 Kent Tamura 2009-12-23 08:30:25 PST
Created attachment 45441 [details]
Proposed patch
Comment 2 WebKit Review Bot 2009-12-23 08:35:32 PST
style-queue ran check-webkit-style on attachment 45441 [details] without any errors.
Comment 3 Maciej Stachowiak 2009-12-28 02:12:27 PST
This patch lacks tests. Perhaps it is only testable in combination with part 2, in which case I'd rather see the two combined into one patch with tests included.
Comment 4 Maciej Stachowiak 2009-12-28 02:13:32 PST
Comment on attachment 45441 [details]
Proposed patch

r- per comment above
Comment 5 Kent Tamura 2009-12-29 08:52:50 PST
Ok, I'm making testable patches.

I have made a new bug, Bug#33021.