Bug 32294 - http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
Summary: http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.5
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 33374 33230 33372
  Show dependency treegraph
 
Reported: 2009-12-08 16:08 PST by Nikolas Zimmermann
Modified: 2010-01-08 14:59 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2010-01-08 02:07 PST, Eric Seidel
no flags Details | Formatted Diff | Diff
proposed fix (3.07 KB, patch)
2010-01-08 14:25 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2009-12-08 16:08:43 PST
Please see the differences between:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/8029
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/8030

LayoutTests/svg/W3C-SVG-1.1/filters-conv-01-f.svg reported 115 as text width instead of 117.
When running the test singly, it reports 115.

Clearly there is a bug and it needs investigation. Anyone?
Comment 2 Eric Seidel 2010-01-08 01:11:13 PST
I'm investigating.
Comment 3 Eric Seidel 2010-01-08 01:30:36 PST
Found the bug.

http/tests/uri/escaped-entity.html changes the results of svg/W3C-SVG-1.1/filters-conv-01-f.svg when run before it.

I suspect some sort of memory smasher, but I don't know yet.

My recommendation is that we skip http/tests/uri/escaped-entity.html

Running http/tests/uri/escaped-entity.html under --guard mode does not crash.
Comment 4 Eric Seidel 2010-01-08 01:59:42 PST
How:
http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/uri/escaped-entity.html
affects:
http://trac.webkit.org/browser/trunk/LayoutTests/svg/W3C-SVG-1.1/filters-conv-01-f.svg

To cause this diff:

--- layout-test-results/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt	2010-01-08 00:17:01.000000000 -0800
+++ layout-test-results/svg/W3C-SVG-1.1/filters-conv-01-f-actual.txt	2010-01-08 00:17:01.000000000 -0800
@@ -39,7 +39,7 @@
             RenderSVGImage {image} at (180,163) size 50x63 [filter=convolve5]
           RenderSVGText {text} at (10,20) size 117x18 contains 1 chunk(s)
             RenderSVGInlineText {#text} at (0,-14) size 117x18
-              chunk 1 text run 1 at (10.00,20.00) startOffset 0 endOffset 19 width 117.00: "Vertical blur (1x3)"
+              chunk 1 text run 1 at (10.00,20.00) startOffset 0 endOffset 19 width 115.00: "Vertical blur (1x3)"
           RenderSVGContainer {g} at (330,163) size 50x63 [transform={m=((1.00,0.00)(0.00,1.00)) t=(300.00,93.00)}]
             RenderSVGImage {image} at (330,163) size 50x63 [filter=convolve6]
     RenderSVGText {text} at (10,340) size 264x46 contains 1 chunk(s)

I do not know.  I can only assume that it's causing some sort of font caching issue or a memory smasher of some sort.  I've not tried to produce a reduced test case yet.
Comment 5 Eric Seidel 2010-01-08 02:07:00 PST
Created attachment 46122 [details]
Patch
Comment 6 Eric Seidel 2010-01-08 02:15:37 PST
Committed r52979: <http://trac.webkit.org/changeset/52979>
Comment 7 Eric Seidel 2010-01-08 02:18:11 PST
(In reply to comment #6)
> Committed r52979: <http://trac.webkit.org/changeset/52979>

That was meant for another bug.
Comment 8 Eric Seidel 2010-01-08 02:23:02 PST
Committed r52980: <http://trac.webkit.org/changeset/52980>
Comment 9 Csaba Osztrogonác 2010-01-08 03:00:54 PST
Unfortunately "Windows Release (Tests)" bot is still wrong, it doesn't generate the correct output for svg/W3C-SVG-1.1/filters-conv-01-f.svg :S

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r52980%20%284022%29/results.html
Comment 10 Eric Seidel 2010-01-08 03:08:42 PST
I wonder if svg/W3C-SVG-1.1/filters-conv-01-f.svg could be reading from uniitialized memory.  Would be nice if we had a valgrind run.
Comment 11 Eric Seidel 2010-01-08 03:09:51 PST
bug 33372 also seems to be the same sort of bug.  We may need to roll out the run-webkit-tests change and fix all these bugs which should appear in --singly runs as well.
Comment 12 Alexey Proskuryakov 2010-01-08 14:25:53 PST
Created attachment 46163 [details]
proposed fix

Filed bug 33400 for the real problem, masking it with changes to escaped-entity.html for now, since the test has no need to render funky characters.
Comment 13 WebKit Review Bot 2010-01-08 14:33:32 PST
style-queue ran check-webkit-style on attachment 46163 [details] without any errors.
Comment 14 Alexey Proskuryakov 2010-01-08 14:59:19 PST
Committed <http://trac.webkit.org/changeset/53012>.