Bug 31853 - bugzilla-tool should have a mark-fixed command
Summary: bugzilla-tool should have a mark-fixed command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-24 16:49 PST by Eric Seidel (no email)
Modified: 2009-12-02 10:00 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2009-11-24 19:05 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2009-11-25 18:12 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (1.31 KB, patch)
2009-11-25 18:19 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-24 16:49:56 PST
bugzilla-tool should have a mark-fixed command

I'm not sure it entirely fits with the current model, but there is the occasional time when you need to commit by hand and it's nice to have bugzilla-tool be able to mark the bug you just commited as fixed/closed.  This could be an "uncommon" command not shown in the standard --help.
Comment 1 Adam Barth 2009-11-24 18:37:24 PST
This is like a five line patch with LandingSequence.  Basically, you just want to run the last step of the landing sequence.
Comment 2 Adam Barth 2009-11-24 19:04:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 3 Adam Barth 2009-11-24 19:04:33 PST
Guess it works.  :)
Comment 4 Adam Barth 2009-11-24 19:05:23 PST
Created attachment 43825 [details]
Patch
Comment 5 Eric Seidel (no email) 2009-11-24 20:27:51 PST
Comment on attachment 43825 [details]
Patch

"All reviewed patches have been landed" seems wrong for this.  Maybe we should prompt for a reason?
Comment 6 Adam Barth 2009-11-24 22:39:50 PST
Maybe it shouldn't leave a comment at all?  Maybe it should prompt for a revision number?
Comment 7 Eric Seidel (no email) 2009-11-25 07:09:07 PST
We could just make "REASON" a required argument.

We could have it confirm that it had found the right bug/revision combo by showing you the bug title.

It could/should also update the bug with the correct revision number and trac link.

I think a version of this which simply required a REASON argument would be a fine first-step though. :)
Comment 8 Adam Barth 2009-11-25 18:07:52 PST
Comment on attachment 43825 [details]
Patch

I think Eric wanted to R- this patch.
Comment 9 Adam Barth 2009-11-25 18:11:55 PST
This is not really fixed.
Comment 10 Adam Barth 2009-11-25 18:12:26 PST
Created attachment 43885 [details]
Patch
Comment 11 Adam Barth 2009-11-25 18:13:01 PST
openzored
Comment 12 Adam Barth 2009-11-25 18:19:17 PST
Created attachment 43886 [details]
Patch
Comment 13 Adam Barth 2009-11-25 18:25:39 PST
Committed r51404: <http://trac.webkit.org/changeset/51404>
Comment 14 David Kilzer (:ddkilzer) 2009-12-02 07:59:36 PST
See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed.
Comment 15 Adam Barth 2009-12-02 09:57:24 PST
(In reply to comment #14)
> See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed.

Holy duplicated code, Batman!
Comment 16 Adam Barth 2009-12-02 10:00:21 PST
Follow up in

https://bugs.webkit.org/show_bug.cgi?id=32073