bugzilla-tool should have a mark-fixed command I'm not sure it entirely fits with the current model, but there is the occasional time when you need to commit by hand and it's nice to have bugzilla-tool be able to mark the bug you just commited as fixed/closed. This could be an "uncommon" command not shown in the standard --help.
This is like a five line patch with LandingSequence. Basically, you just want to run the last step of the landing sequence.
All reviewed patches have been landed. Closing bug.
Guess it works. :)
Created attachment 43825 [details] Patch
Comment on attachment 43825 [details] Patch "All reviewed patches have been landed" seems wrong for this. Maybe we should prompt for a reason?
Maybe it shouldn't leave a comment at all? Maybe it should prompt for a revision number?
We could just make "REASON" a required argument. We could have it confirm that it had found the right bug/revision combo by showing you the bug title. It could/should also update the bug with the correct revision number and trac link. I think a version of this which simply required a REASON argument would be a fine first-step though. :)
Comment on attachment 43825 [details] Patch I think Eric wanted to R- this patch.
This is not really fixed.
Created attachment 43885 [details] Patch
openzored
Created attachment 43886 [details] Patch
Committed r51404: <http://trac.webkit.org/changeset/51404>
See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed.
(In reply to comment #14) > See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed. Holy duplicated code, Batman!
Follow up in https://bugs.webkit.org/show_bug.cgi?id=32073