WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28910
Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
https://bugs.webkit.org/show_bug.cgi?id=28910
Summary
Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
David Kilzer (:ddkilzer)
Reported
2009-09-02 08:34:27 PDT
* SUMMARY The bugzilla-tool command is getting crowded. Move the mark-fixed subcommand to its own tool named mark-bug-fixed. * NOTES See
Bug 28877 Comment #7
and
Bug 28877 Comment #8
.
Attachments
Patch v1
(13.77 KB, patch)
2009-09-23 19:27 PDT
,
David Kilzer (:ddkilzer)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-09-02 13:55:25 PDT
We could move all of the commands into a separate commands.py, or just this command into a module which was then loaded an execute manually called by some wrapper script. I think I want to move away from having BugzillaTool hold all of the shared state, and instead have something on the Command baseclass. I want to basically kill the BugzillaTool class over time, and split the option parsing stuff off into its own class/file and the state off into some Command base class.
David Kilzer (:ddkilzer)
Comment 2
2009-09-02 19:20:14 PDT
(In reply to
comment #1
)
> We could move all of the commands into a separate commands.py, or just this > command into a module which was then loaded an execute manually called by some > wrapper script. > > I think I want to move away from having BugzillaTool hold all of the shared > state, and instead have something on the Command baseclass. I want to > basically kill the BugzillaTool class over time, and split the option parsing > stuff off into its own class/file and the state off into some Command base > class.
So I completely misunderstood
Bug 28877 Comment #7
? Or is it okay to move this out?
Eric Seidel (no email)
Comment 3
2009-09-02 22:58:01 PDT
You're welcome to do whatever you like. :) In general the idea behind doing all the Command subclasses was to share as much setup/teardown code as possible. But that shouldn't hold you back from writing other python scripts which use all of our new python modules. :)
David Kilzer (:ddkilzer)
Comment 4
2009-09-23 19:20:53 PDT
***
Bug 29699
has been marked as a duplicate of this bug. ***
David Kilzer (:ddkilzer)
Comment 5
2009-09-23 19:27:05 PDT
Created
attachment 40035
[details]
Patch v1
David Kilzer (:ddkilzer)
Comment 6
2009-09-23 22:01:11 PDT
Committed
r48700
: <
http://trac.webkit.org/changeset/48700
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug