WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32073
We have two mark-fixed commands
https://bugs.webkit.org/show_bug.cgi?id=32073
Summary
We have two mark-fixed commands
Adam Barth
Reported
2009-12-02 09:59:52 PST
There should be only one! It seems like we're been favoring putting more commands into bugzilla-tool, where they can share a bunch of infrastructure. What do you think? Should we port the extra functionality from mark-bug-fixed to bugzilla-tool mark-fixed, or should we kill the bugzilla-tool command?
Attachments
Patch
(12.25 KB, patch)
2009-12-15 03:06 PST
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-12-02 10:01:51 PST
I never intended for there to be 2. We could easily just delete the bzt one. I think some of the apple folks who use the mark-as-fixed command prefer it to be a stand-alone command, so we should kill the bzt one. However, we could/should consider replacing the guts of mark-as-fixed with a python implementation which uses all our nifty infrastructure. :)
Adam Barth
Comment 2
2009-12-02 10:06:58 PST
mark-bug-fixed does use Python! Go look at it. :) The problem is that it's been left behind in the march of bugzilla-tool technology. It's using stone knives and bear skins.
David Kilzer (:ddkilzer)
Comment 3
2009-12-02 10:57:50 PST
The mark-BUG-fixed script was moved to a separate script so that it would be less...confusing...to developers who didn't like deciphering the cacophony of subcommands in bugzilla-tool --help. However, I don't think that this experiment was a success, and since the script was not updated with the other bugzilla-tool refactoring, and because bugzilla-tool now has help for individual sub-commands, I'm slightly in favor of it being rolled back into bugzilla-tool.
Eric Seidel (no email)
Comment 4
2009-12-02 11:11:16 PST
We can make it easy to make any Command object into an individual script. Something like this: mark-as-fixed #!/bin/python from modules.commands.mark_as_fixed import MarkAsFixed if __name__ == "__main__": MarkAsFixed().check_arguments_and_execute(sys.argv, None) That won't work out of the box yet, because Commands don't deal well with tool being None, but that can easily be fixed. We'd probably want to call some special run_as_stand_alone_command(sys.argv) call instead of check_arguments_and_execute directly anyway.
Eric Seidel (no email)
Comment 5
2009-12-02 11:12:11 PST
Heck, we could even write a script to auto-gen individual command wrapper files from bugzilla-tool sub-commands if necessary. :)
Eric Seidel (no email)
Comment 6
2009-12-02 11:17:13 PST
(In reply to
comment #2
)
> mark-bug-fixed does use Python! Go look at it. :) > > The problem is that it's been left behind in the march of bugzilla-tool > technology. It's using stone knives and bear skins.
Wow, yeah, I *totally* forgot about
bug 28910
!
Adam Barth
Comment 7
2009-12-15 03:06:28 PST
Created
attachment 44858
[details]
Patch
Eric Seidel (no email)
Comment 8
2009-12-15 03:08:41 PST
Comment on
attachment 44858
[details]
Patch Hmm.. OK. Assuming it still works. This seems like a only semi-useful stop-gap measure.
Adam Barth
Comment 9
2009-12-15 03:10:42 PST
Committed
r52142
: <
http://trac.webkit.org/changeset/52142
>
Adam Barth
Comment 10
2009-12-15 03:13:01 PST
(In reply to
comment #9
)
> Committed
r52142
: <
http://trac.webkit.org/changeset/52142
>
Actually committed in
r52148
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug