Bug 32073 - We have two mark-fixed commands
Summary: We have two mark-fixed commands
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-02 09:59 PST by Adam Barth
Modified: 2009-12-15 03:13 PST (History)
3 users (show)

See Also:

Patch (12.25 KB, patch)
2009-12-15 03:06 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-02 09:59:52 PST
There should be only one!

It seems like we're been favoring putting more commands into bugzilla-tool, where they can share a bunch of infrastructure.  What do you think?  Should we port the extra functionality from mark-bug-fixed to bugzilla-tool mark-fixed, or should we kill the bugzilla-tool command?
Comment 1 Eric Seidel (no email) 2009-12-02 10:01:51 PST
I never intended for there to be 2.  We could easily just delete the bzt one.  I think some of the apple folks who use the mark-as-fixed command prefer it to be a stand-alone command, so we should kill the bzt one.  However, we could/should consider replacing the guts of mark-as-fixed with a python implementation which uses all our nifty infrastructure. :)
Comment 2 Adam Barth 2009-12-02 10:06:58 PST
mark-bug-fixed does use Python!  Go look at it.  :)

The problem is that it's been left behind in the march of bugzilla-tool technology.  It's using stone knives and bear skins.
Comment 3 David Kilzer (:ddkilzer) 2009-12-02 10:57:50 PST
The mark-BUG-fixed script was moved to a separate script so that it would be less...confusing...to developers who didn't like deciphering the cacophony of subcommands in bugzilla-tool --help.

However, I don't think that this experiment was a success, and since the script was not updated with the other bugzilla-tool refactoring, and because bugzilla-tool now has help for individual sub-commands, I'm slightly in favor of it being rolled back into bugzilla-tool.
Comment 4 Eric Seidel (no email) 2009-12-02 11:11:16 PST
We can make it easy to make any Command object into an individual script.

Something like this:


from modules.commands.mark_as_fixed import MarkAsFixed

if __name__ == "__main__":
    MarkAsFixed().check_arguments_and_execute(sys.argv, None)

That won't work out of the box yet, because Commands don't deal well with tool being None, but that can easily be fixed.  We'd probably want to call some special run_as_stand_alone_command(sys.argv) call instead of check_arguments_and_execute directly anyway.
Comment 5 Eric Seidel (no email) 2009-12-02 11:12:11 PST
Heck, we could even write a script to auto-gen individual command wrapper files from bugzilla-tool sub-commands if necessary. :)
Comment 6 Eric Seidel (no email) 2009-12-02 11:17:13 PST
(In reply to comment #2)
> mark-bug-fixed does use Python!  Go look at it.  :)
> The problem is that it's been left behind in the march of bugzilla-tool
> technology.  It's using stone knives and bear skins.

Wow, yeah, I *totally* forgot about bug 28910!
Comment 7 Adam Barth 2009-12-15 03:06:28 PST
Created attachment 44858 [details]
Comment 8 Eric Seidel (no email) 2009-12-15 03:08:41 PST
Comment on attachment 44858 [details]

Hmm.. OK.  Assuming it still works.   This seems like a only semi-useful stop-gap measure.
Comment 9 Adam Barth 2009-12-15 03:10:42 PST
Committed r52142: <http://trac.webkit.org/changeset/52142>
Comment 10 Adam Barth 2009-12-15 03:13:01 PST
(In reply to comment #9)
> Committed r52142: <http://trac.webkit.org/changeset/52142>

Actually committed in r52148