Bug 31231 - Closing brace in value breaks CSS parser
Summary: Closing brace in value breaks CSS parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 26619 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-11-07 15:17 PST by Alexey Proskuryakov
Modified: 2010-01-13 22:05 PST (History)
5 users (show)

See Also:

Attachments
test 1 (201 bytes, text/html)
2009-11-07 15:17 PST, Alexey Proskuryakov 		no flags Details
test 2 (110 bytes, text/html)
2009-11-07 15:17 PST, Alexey Proskuryakov 		no flags Details
Skip invalid blocks in CSS property declarations. (3.86 KB, patch)
2010-01-07 23:59 PST, Yuzo Fujishima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-11-07 15:17:13 PST 
Created attachment 42705 [details]
test 1

From <http://habrahabr.ru/blogs/css/74565>.

After e.g. '.myclass {height:{}}', nothing else gets parsed. See attached test cases.
Comment 1 Alexey Proskuryakov 2009-11-07 15:17:33 PST 
Created attachment 42706 [details]
test 2
Comment 2 Yuzo Fujishima 2010-01-07 23:59:09 PST 
Created attachment 46117 [details]
Skip invalid blocks in CSS property declarations.
Comment 3 WebKit Review Bot 2010-01-07 23:59:51 PST 
style-queue ran check-webkit-style on attachment 46117 [details] without any errors.
Comment 4 Yuzo Fujishima 2010-01-08 00:00:43 PST 
The above patch should also fix 26619.

Yuzo
Comment 5 WebKit Commit Bot 2010-01-08 13:31:40 PST 
Comment on attachment 46117 [details]
Skip invalid blocks in CSS property declarations.

Clearing flags on attachment: 46117

Committed r53004: <http://trac.webkit.org/changeset/53004>
Comment 6 WebKit Commit Bot 2010-01-08 13:31:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Yuzo Fujishima 2010-01-11 20:11:28 PST 
*** Bug 26619 has been marked as a duplicate of this bug. ***
Comment 8 Adele Peterson 2010-01-13 22:05:07 PST 
This change introduced a serious bug at redfin.com - https://bugs.webkit.org/show_bug.cgi?id=33650