Bug 33650 - REGRESSION (r53004): Page layout is broken at http://www.redfin.com listings
Summary: REGRESSION (r53004): Page layout is broken at http://www.redfin.com listings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2010-01-13 22:02 PST by Adele Peterson
Modified: 2010-01-18 18:53 PST (History)
3 users (show)

See Also:


Attachments
reduction (357 bytes, text/html)
2010-01-13 22:02 PST, Adele Peterson
no flags Details
Skip error after invalid blocks in function argument. (2.60 KB, patch)
2010-01-17 22:38 PST, Yuzo Fujishima
no flags Details | Formatted Diff | Diff
Skip an error after invalid blocks in a CSS expression. (2.60 KB, patch)
2010-01-17 22:43 PST, Yuzo Fujishima
hyatt: review-
hyatt: commit-queue-
Details | Formatted Diff | Diff
Skip an error after invalid blocks in a CSS expression. (2.60 KB, patch)
2010-01-18 17:00 PST, Yuzo Fujishima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2010-01-13 22:02:05 PST
Created attachment 46539 [details]
reduction

Load any redfin.com listing page, like: http://www.redfin.com/CA/San-Jose/3070-Crystal-Creek-Dr-95133/home/1571004

The CSS doesn't parse correctly, and the page layout is seriously broken.

Introduced in http://trac.webkit.org/changeset/53004

<rdar://problem/7540863>
Comment 1 Yuzo Fujishima 2010-01-17 22:38:43 PST
Created attachment 46788 [details]
Skip error after invalid blocks in function argument.
Comment 2 Yuzo Fujishima 2010-01-17 22:43:48 PST
Created attachment 46789 [details]
Skip an error after invalid blocks in a CSS expression.
Comment 3 Yuzo Fujishima 2010-01-17 22:45:01 PST
Hi,

Sorry for the regression. Can someone review the patch?

Yuzo
Comment 4 Adele Peterson 2010-01-18 10:29:35 PST
CCing Hyatt to see if he'd like to review
Comment 5 Dave Hyatt 2010-01-18 12:02:51 PST
Comment on attachment 46789 [details]
Skip an error after invalid blocks in a CSS expression.

Your test case is wrong.  You meant to use test4 as the id.
Comment 6 Yuzo Fujishima 2010-01-18 17:00:54 PST
Created attachment 46865 [details]
Skip an error after invalid blocks in a CSS expression.
Comment 7 Yuzo Fujishima 2010-01-18 17:02:37 PST
Thank you for the review.

Fixed the test id. Can you take another look?

Yuzo
Comment 8 WebKit Commit Bot 2010-01-18 18:53:22 PST
Comment on attachment 46865 [details]
Skip an error after invalid blocks in a CSS expression.

Clearing flags on attachment: 46865

Committed r53448: <http://trac.webkit.org/changeset/53448>
Comment 9 WebKit Commit Bot 2010-01-18 18:53:28 PST
All reviewed patches have been landed.  Closing bug.