Bug 29316 – commit-queue should give better feedback when failing a patch

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

commit-queue should give better feedback when failing a patch

I'm going to start by printing the logs from the failing command.  I will make further improvements soon, including giving information as to how to resolve the issue, or changing other parts of the commit-queue to not even bother failing a patch when it's not the user's fault (like when the ChangeLog is out of date, or maybe for a specific set of flakey tests).

This patch is about adding logging information when failing a patch.  I've been running the commit-queue with this code for a few hours and it seems to be doing fine. :)

[Eric Seidel (no email)]

Created attachment 39663 [details]
First attempt at error message cleanups

[Eric Seidel (no email)]

Example feedback:
https://bugs.webkit.org/show_bug.cgi?id=29280#c4

Obviously that message could be much less verbose.  That's the next step: write custom message parsers/translators for all the individual errors and tools.

In this example, we could parse out what layout test failed, and compose a more concise message that we post in the bug.

[Eric Seidel (no email)]

Created attachment 39667 [details]
Fix args to not conflict with Exception.args

[Eric Seidel (no email)]

Created attachment 39673 [details]
Fix args to not conflict with Exception.args

[Adam Barth]

Comment on attachment 39673 [details]
Fix args to not conflict with Exception.args

ok

[Eric Seidel (no email)]

Comment on attachment 39673 [details]
Fix args to not conflict with Exception.args

I rescind this patch.  I just noticed it's not logging to stdout as expected, I need to debug it further.

[Eric Seidel (no email)]

Created attachment 40080 [details]
Limit error output length

[Eric Seidel (no email)]

I've been testing this patch for the last week.  It seems to work just fine, and has dramatically improved usability of the queue now that people can see what fails.  I still need to deploy this type of reporting to a few other places in the code though.

[Adam Barth]

Comment on attachment 40080 [details]
Limit error output length

That python array syntax is wild.

[WebKit Commit Bot]

Comment on attachment 40080 [details]
Limit error output length

Clearing flags on attachment: 40080

Committed r48760: <http://trac.webkit.org/changeset/48760>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.