Bug 28686 - bugzilla-tool should not put debug output in bugs when it fails to land a patch
Summary: bugzilla-tool should not put debug output in bugs when it fails to land a patch
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL: https://bugs.webkit.org/show_bug.cgi?...
Depends on: 29316
  Show dependency treegraph
Reported: 2009-08-24 13:50 PDT by Mark Rowe (bdash)
Modified: 2019-05-02 16:18 PDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2009-08-24 13:50:08 PDT
In bug 28670 there is the message:
> Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None

This debugging output is noise.  There's no reason for it to be added to the bug comments.
Comment 1 Eric Seidel (no email) 2009-08-24 14:17:51 PDT
This particular one is not very useful for certain.  In general other failures from this same logging infrastructure are useful:

I recently added the ability for the commit-queue to record per-bug logs.  I've not yet added the ability to upload those logs somewhere (like as attachments on the bug) when things fail yet.

Ideally we would print a nicer message which doesn't involve a python array and we would either point to/attach a log or include the failing log snippet.

Hopefully most of the git svn dcommit and git svn rebase errors will go away by fixing bug 27355 and bug 13734.
Comment 2 Eric Seidel (no email) 2009-08-25 13:14:36 PDT
Hum.  We certainly could turn these into better error messages.

'dcommit' failures are generally ChangeLogs changing between update and commit, or tabs in the ChangeLog.  Figuring out which error is which will require parsing the git svn dcommit spew (which is possible, just needs a bunch of code written.)

'rebase' shouldn't happen anymore.  They were caused by an experimental work-around for the 'dcommit' ChangeLog problem above.  Obviously the workaround didn't quite work. :)  Eventually we need to fix bug 27162 so that update-webkit works for Git.  That will get around the "ChangeLogs out of date" problem.
Comment 3 David Kilzer (:ddkilzer) 2009-08-28 09:40:59 PDT
Bug 28040 Comment #13 (and #15 and #17) is another case where the error message isn't very useful:

> ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet',
> '--exit-after-n-failures=1'] failed with exit code 1

The commit-queue mode should be printing the failing tests (if anything), not the failing command.
Comment 4 Eric Seidel (no email) 2009-09-11 11:35:23 PDT
Ok.  I'm going to address this today.  I'll add better error messages and a work-around for bug 28316 as described in https://bugs.webkit.org/show_bug.cgi?id=28831#c16.
Comment 5 Eric Seidel (no email) 2009-09-15 13:21:33 PDT
I have a patch locally which I'm testing.  I'll upload it after I've run it successfully for a while.
Comment 6 Eric Seidel (no email) 2009-09-16 15:28:51 PDT
I've made some of the improvements suggested in bug 29316, but not everything yet, so I've made that a dependent bug.  Most notably the output still look like "debug output" because it's printing a python array.  I intend to replace that with better error messages for the specific failures, including directions on how to resolve the failures soon.  For now we're just logging more "debug output", hopefully more useful stuff now. :)
Comment 7 Eric Seidel (no email) 2009-10-23 14:39:02 PDT
The "debug output" continues, but has been dramatically improved.  I'm not sure that it should really be replaced by anything else, but I'm certainly open to suggestions.

https://bugs.webkit.org/show_bug.cgi?id=27239#c24 is an example of more modern output.
Comment 8 Eric Seidel (no email) 2009-12-10 00:11:39 PST
I believe this bug is resolved.  If you disagreed, please re-open with additional comments and I'll be happy to make further tweaks to bugzilla-tool.  Thanks!