RESOLVED FIXED Bug 29280
On Windows7 add missing Windows 6.1 to the user agent 
https://bugs.webkit.org/show_bug.cgi?id=29280
Summary On Windows7 add missing Windows 6.1 to the user agent
Benjamin Meyer
Reported 2009-09-15 14:41:17 PDT
Created attachment 39615 [details] fix currently the windows version is "" on Windows7 because that case is not handled. This should probably go in 4.5.3 also.
Attachments
fix (1.52 KB, patch)
2009-09-15 14:41 PDT, Benjamin Meyer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-09-15 18:05:15 PDT
Comment on attachment 39615 [details] fix LGTM. What's with the strange ChangeLog diff?
Benjamin Meyer
Comment 2 2009-09-15 18:16:42 PDT
The changelog is the same one I always submit (using the prepare-changelog script), should it look different?
Eric Seidel (no email)
Comment 3 2009-09-16 15:38:34 PDT
Comment on attachment 39615 [details] fix Filed bug 29317. Did you edit your patch file by hand? If so then please close bug 29317 as invalid. I guess we'll add this to the commit-queue and see if it rejects your diff.
WebKit Commit Bot
Comment 4 2009-09-16 15:53:50 PDT
Comment on attachment 39615 [details] fix Rejecting patch 39615 from commit-queue. ('WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1') Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11265 test cases. media/video-source-error.html -> timed out Sampling process 50978 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 50978 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 9110 tests run. 526.85s total testing time 9109 test cases (99%) succeeded 1 test case (<1%) timed out 5 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 5 2009-09-16 15:59:02 PDT
Comment on attachment 39615 [details] fix You were bit by bug 28845. Adding back to the queue.
WebKit Commit Bot
Comment 6 2009-09-16 16:14:12 PDT
Comment on attachment 39615 [details] fix Clearing flags on attachment: 39615 Committed r48444: <http://trac.webkit.org/changeset/48444>
WebKit Commit Bot
Comment 7 2009-09-16 16:14:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.