WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 28605
28916
patches marked cq+ without review will hang the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=28916
Summary
patches marked cq+ without review will hang the commit-queue
Eric Seidel (no email)
Reported
2009-09-02 13:03:15 PDT
patches marked cq+ without review will hang the commit-queue The queue spins infinitely. It thinks it has something to land, but then when it goes to land it, it doesn't find a patch and thus it just loops indefinitely. :(
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-09-02 13:03:35 PDT
https://bugs.webkit.org/show_bug.cgi?id=28887
caused the hang this evening.
Eric Seidel (no email)
Comment 2
2009-09-08 14:11:50 PDT
This will be fixed by the patch on
bug 28605
. The fix was to make the commit queue call the fetch_patches_from_commit_queue up front instead of fetch_bug_ids_from_commit_queue so that it is sure to validate the patches before passing them off to land-patches. *** This bug has been marked as a duplicate of
bug 28605
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug