patches marked cq+ without review will hang the commit-queue The queue spins infinitely. It thinks it has something to land, but then when it goes to land it, it doesn't find a patch and thus it just loops indefinitely. :(
https://bugs.webkit.org/show_bug.cgi?id=28887 caused the hang this evening.
This will be fixed by the patch on bug 28605. The fix was to make the commit queue call the fetch_patches_from_commit_queue up front instead of fetch_bug_ids_from_commit_queue so that it is sure to validate the patches before passing them off to land-patches. *** This bug has been marked as a duplicate of bug 28605 ***