Bug 28916 – patches marked cq+ without review will hang the commit-queue

Bug 28916 - patches marked cq+ without review will hang the commit-queue


Summary:	patches marked cq+ without review will hang the commit-queue

Status:	RESOLVED DUPLICATE of bug 28605

Product:	WebKit
Component:	Tools / Tests
Version:	528+ (Nightly build)
Platform:	PC Mac OS X 10.5

Importance:	P2 Normal
Assigned To:	Nobody

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-09-02 13:03 PST by Eric Seidel
Modified:	2009-09-08 14:11 PST (History)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Eric Seidel 2009-09-02 13:03:15 PST

patches marked cq+ without review will hang the commit-queue

The queue spins infinitely.  It thinks it has something to land, but then when it goes to land it, it doesn't find a patch and thus it just loops indefinitely. :(

------- Comment #1 From Eric Seidel 2009-09-02 13:03:35 PST -------

https://bugs.webkit.org/show_bug.cgi?id=28887 caused the hang this evening.

------- Comment #2 From Eric Seidel 2009-09-08 14:11:50 PST -------

This will be fixed by the patch on bug 28605.  The fix was to make the commit queue call the fetch_patches_from_commit_queue up front instead of fetch_bug_ids_from_commit_queue so that it is sure to validate the patches before passing them off to land-patches.

*** This bug has been marked as a duplicate of bug 28605 ***