Bug 28605 - commit-queue gets stuck if a non-committer sets commit-queue+ or review+
Summary: commit-queue gets stuck if a non-committer sets commit-queue+ or review+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 28321 28916 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-08-20 23:05 PDT by Adam Barth
Modified: 2009-09-09 10:36 PDT (History)
2 users (show)

See Also:

Attachments
first pass (11.37 KB, patch)
2009-09-08 12:34 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch v1 (14.64 KB, patch)
2009-09-08 14:17 PDT, Eric Seidel (no email) 		levin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-08-20 23:05:57 PDT 
Back from the grave:

          Summary: commit-queue gets stuck if a non-committer sets
                   commit-queue+ or review+
          Product: WebKit
          Version: 528+ (Nightly build)
         Platform: PC
       OS/Version: Mac OS X 10.5
           Status: NEW
         Severity: Normal
         Priority: P2
        Component: Tools / Tests
       AssignedTo: webkit-unassigned@lists.webkit.org
       ReportedBy: eric@webkit.org
               CC: abarth@webkit.org


commit-queue gets stuck if a non-committer sets commit-queue+ or review+

The checking for commit-queue/review is done outside of the try/catch.  We need
to catch these specially and handle clearing flags properly.
Comment 1 Eric Seidel (no email) 2009-09-08 12:34:06 PDT 
*** Bug 28321 has been marked as a duplicate of this bug. ***
Comment 2 Eric Seidel (no email) 2009-09-08 12:34:49 PDT 
Created attachment 39206 [details]
first pass


---
 5 files changed, 62 insertions(+), 35 deletions(-)
Comment 3 Eric Seidel (no email) 2009-09-08 14:11:50 PDT 
*** Bug 28916 has been marked as a duplicate of this bug. ***
Comment 4 Eric Seidel (no email) 2009-09-08 14:17:20 PDT 
Created attachment 39212 [details]
Patch v1
Comment 5 Eric Seidel (no email) 2009-09-08 14:34:16 PDT 
Just in case dave levin has interest in this hot hot python action.
Comment 6 David Levin 2009-09-08 14:40:01 PDT 
Comment on attachment 39212 [details]
Patch v1


> diff --git a/WebKitTools/Scripts/bugzilla-tool b/WebKitTools/Scripts/bugzilla-tool

> +                patch_ids = map(lambda p: p['id'], patches)
s/p/patch/ would be nice.
Comment 7 Eric Seidel (no email) 2009-09-09 10:36:58 PDT 
Committed r48214: <http://trac.webkit.org/changeset/48214>