Bug 28605 – commit-queue gets stuck if a non-committer sets commit-queue+ or review+

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Barth]

Back from the grave:

          Summary: commit-queue gets stuck if a non-committer sets
                   commit-queue+ or review+
          Product: WebKit
          Version: 528+ (Nightly build)
         Platform: PC
       OS/Version: Mac OS X 10.5
           Status: NEW
         Severity: Normal
         Priority: P2
        Component: Tools / Tests
       AssignedTo: [e-mail]
       ReportedBy: [e-mail]
               CC: [e-mail]


commit-queue gets stuck if a non-committer sets commit-queue+ or review+

The checking for commit-queue/review is done outside of the try/catch.  We need
to catch these specially and handle clearing flags properly.

[Eric Seidel (no email)]

*** Bug 28321 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

Created attachment 39206 [details]
first pass


---
 5 files changed, 62 insertions(+), 35 deletions(-)

[Eric Seidel (no email)]

*** Bug 28916 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

Created attachment 39212 [details]
Patch v1

[Eric Seidel (no email)]

Just in case dave levin has interest in this hot hot python action.

[David Levin]

Comment on attachment 39212 [details]
Patch v1


> diff --git a/WebKitTools/Scripts/bugzilla-tool b/WebKitTools/Scripts/bugzilla-tool

> +                patch_ids = map(lambda p: p['id'], patches)
s/p/patch/ would be nice.

[Eric Seidel (no email)]

Committed r48214: <http://trac.webkit.org/changeset/48214>