RESOLVED DUPLICATE of bug 2860528321
bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches 
https://bugs.webkit.org/show_bug.cgi?id=28321
Summary bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches
Eric Seidel (no email)
Reported 2009-08-14 14:52:57 PDT
bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches bugzilla-tool properly detects when a pach has r+ or cq+ set by someone who does not have proper rights. However it doesn't know how to clean up the bug after that. It should clear flags which have been set erroneously. What makes this tricky is the current architecture is to do that lookups/validation inside the patch fetch function. Which is wrong. We should get all the patch information in one function and validate the patches separately. Or at least have some sort of validate=True flag which is passed to the fetch function. I have a partial patch on my machine, but I'll have to finish it later...
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-09-08 12:34:06 PDT
Fixing this as part of bug 28605. *** This bug has been marked as a duplicate of bug 28605 ***
Note You need to log in before you can comment on or make changes to this bug.