Bug 28887 - Expose functions to change the focus ring color for Linux Chromium
: Expose functions to change the focus ring color for Linux Chromium
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-09-01 13:12 PST by
Modified: 2009-09-02 13:46 PST (History)


Attachments
patch (2.61 KB, patch)
2009-09-01 13:15 PST, Evan Stade
levin: review+
levin: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
ditched variable name (2.60 KB, patch)
2009-09-02 11:32 PST, Evan Stade
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-01 13:12:57 PST
we will use this to make the focus ring match the system theme.
------- Comment #1 From 2009-09-01 13:15:23 PST -------
Created an attachment (id=38882) [details]
patch
------- Comment #2 From 2009-09-01 13:15:55 PST -------
chromium side is http://codereview.chromium.org/173642
------- Comment #3 From 2009-09-01 15:53:00 PST -------
I am not a WebKit reviewer. You'll have to send it to someone who is, but LGTM.
------- Comment #4 From 2009-09-01 22:16:45 PST -------
(From update of attachment 38882 [details])
> Index: WebCore/rendering/RenderThemeChromiumLinux.h
> +        void setFocusRingColor(const Color& color);

Parameter names shouldn't be included if they don't add information, so remove "color" on landing this.
------- Comment #5 From 2009-09-02 10:36:59 PST -------
thanks for the review. I am not a committer.
------- Comment #6 From 2009-09-02 10:38:05 PST -------
estate: if you update the patch, I can mark it for commit queue.
------- Comment #7 From 2009-09-02 11:32:29 PST -------
Created an attachment (id=38934) [details]
ditched variable name

updated
------- Comment #8 From 2009-09-02 13:04:51 PST -------
(From update of attachment 38934 [details])
Turns out the commit-queue spins if patches are marked cq+ w/o being reviewd. :(  bug 28916.  I'll fix it.  But for now, markign this r+ too. :)
------- Comment #9 From 2009-09-02 13:05:40 PST -------
(From update of attachment 38934 [details])
Rejecting patch 38934 from commit-queue.  This patch will require manual commit.

WebKitTools/Scripts/build-webkit failed with exit code 1
------- Comment #10 From 2009-09-02 13:10:26 PST -------
does the above message mean that it failed to compile?
------- Comment #11 From 2009-09-02 13:20:48 PST -------
(From update of attachment 38934 [details])
build-webkit was broken for a moment.  Not sure why the bots weren't showing it.
------- Comment #12 From 2009-09-02 13:31:33 PST -------
(From update of attachment 38934 [details])
Rejecting patch 38934 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None
------- Comment #13 From 2009-09-02 13:34:18 PST -------
(From update of attachment 38934 [details])
The commit-queue hates us tonight.  Race condition during commit.  bug 28316.
------- Comment #14 From 2009-09-02 13:45:56 PST -------
(From update of attachment 38934 [details])
Clearing flags on attachment: 38934

Committed r47992: <http://trac.webkit.org/changeset/47992>
------- Comment #15 From 2009-09-02 13:46:00 PST -------
All reviewed patches have been landed.  Closing bug.