Bug 28887 - Expose functions to change the focus ring color for Linux Chromium
: Expose functions to change the focus ring color for Linux Chromium
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-01 13:12 PDT by Evan Stade
Modified: 2009-09-02 13:46 PDT (History)
2 users (show)

See Also:


Attachments
patch (2.61 KB, patch)
2009-09-01 13:15 PDT, Evan Stade
levin: review+
levin: commit‑queue-
Details | Formatted Diff | Diff
ditched variable name (2.60 KB, patch)
2009-09-02 11:32 PDT, Evan Stade
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Stade 2009-09-01 13:12:57 PDT
we will use this to make the focus ring match the system theme.
Comment 1 Evan Stade 2009-09-01 13:15:23 PDT
Created attachment 38882 [details]
patch
Comment 2 Evan Stade 2009-09-01 13:15:55 PDT
chromium side is http://codereview.chromium.org/173642
Comment 3 Adam Langley 2009-09-01 15:53:00 PDT
I am not a WebKit reviewer. You'll have to send it to someone who is, but LGTM.
Comment 4 David Levin 2009-09-01 22:16:45 PDT
Comment on attachment 38882 [details]
patch

> Index: WebCore/rendering/RenderThemeChromiumLinux.h
> +        void setFocusRingColor(const Color& color);

Parameter names shouldn't be included if they don't add information, so remove "color" on landing this.
Comment 5 Evan Stade 2009-09-02 10:36:59 PDT
thanks for the review. I am not a committer.
Comment 6 Adam Langley 2009-09-02 10:38:05 PDT
estate: if you update the patch, I can mark it for commit queue.
Comment 7 Evan Stade 2009-09-02 11:32:29 PDT
Created attachment 38934 [details]
ditched variable name

updated
Comment 8 Eric Seidel 2009-09-02 13:04:51 PDT
Comment on attachment 38934 [details]
ditched variable name

Turns out the commit-queue spins if patches are marked cq+ w/o being reviewd. :(  bug 28916.  I'll fix it.  But for now, markign this r+ too. :)
Comment 9 Eric Seidel 2009-09-02 13:05:40 PDT
Comment on attachment 38934 [details]
ditched variable name

Rejecting patch 38934 from commit-queue.  This patch will require manual commit.

WebKitTools/Scripts/build-webkit failed with exit code 1
Comment 10 Evan Stade 2009-09-02 13:10:26 PDT
does the above message mean that it failed to compile?
Comment 11 Eric Seidel 2009-09-02 13:20:48 PDT
Comment on attachment 38934 [details]
ditched variable name

build-webkit was broken for a moment.  Not sure why the bots weren't showing it.
Comment 12 Eric Seidel 2009-09-02 13:31:33 PDT
Comment on attachment 38934 [details]
ditched variable name

Rejecting patch 38934 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None
Comment 13 Eric Seidel 2009-09-02 13:34:18 PDT
Comment on attachment 38934 [details]
ditched variable name

The commit-queue hates us tonight.  Race condition during commit.  bug 28316.
Comment 14 Eric Seidel 2009-09-02 13:45:56 PDT
Comment on attachment 38934 [details]
ditched variable name

Clearing flags on attachment: 38934

Committed r47992: <http://trac.webkit.org/changeset/47992>
Comment 15 Eric Seidel 2009-09-02 13:46:00 PDT
All reviewed patches have been landed.  Closing bug.