WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
285569
Add test so that
bug 285568
can't happen again
https://bugs.webkit.org/show_bug.cgi?id=285569
Summary
Add test so that bug 285568 can't happen again
Jean-Yves Avenard [:jya]
Reported
2025-01-07 18:27:34 PST
In
https://bugs.webkit.org/show_bug.cgi?id=285568
, we reverted
https://bugs.webkit.org/show_bug.cgi?id=283172
as it broke a major web site (Duolingo). The change in 283172 prevented a call to `MediaPlayer::play()` if we were in the middle of a seek (it had exception to bypass the new logic) if currentTime was >= duration which isn't sufficient, currentTime could be at 0 if we do seek to 0 -> play() Having play() being called and acted upon during seek() is allowed by the spec. If GStreamer has an issue there, it should be handled in MediaPlayerPrivateGStreamer rather than in HTMLMediaElement. We need a test so that any future change as done in
bug 283172
can't happen again.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-01-07 18:27:55 PST
<
rdar://problem/142517881
>
Jean-Yves Avenard [:jya]
Comment 2
2025-01-08 01:21:23 PST
Pull request:
https://github.com/WebKit/WebKit/pull/38710
EWS
Comment 3
2025-01-08 06:07:31 PST
Committed
288590@main
(4bdbf870a50a): <
https://commits.webkit.org/288590@main
> Reviewed commits have been landed. Closing PR #38710 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug