WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
283172
[Media] Avoid play() call during seek flow before the finishSeek() call
https://bugs.webkit.org/show_bug.cgi?id=283172
Summary
[Media] Avoid play() call during seek flow before the finishSeek() call
Enrique Ocaña
Reported
2024-11-15 06:05:06 PST
During the video playback states should ideally flow as play -> pause -> seek_start -> seek_done -> play, but randomly it is observed that the play event is being sent before finishing the seek (seek_done) i.e, play -> pause -> seek_start -> play -> seek_done. Ideally play call might be triggered continuously by the webapp when we are playing a video, so in our scenario between seek_start and seek_done we should avoid the play call. See:
https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423
Attachments
Add attachment
proposed patch, testcase, etc.
Enrique Ocaña
Comment 1
2024-11-15 06:14:54 PST
Pull request:
https://github.com/WebKit/WebKit/pull/36695
Radar WebKit Bug Importer
Comment 2
2024-11-22 06:06:14 PST
<
rdar://problem/140414465
>
EWS
Comment 3
2024-12-03 04:14:55 PST
Committed
287274@main
(71a7e0a09291): <
https://commits.webkit.org/287274@main
> Reviewed commits have been landed. Closing PR #36695 and removing active labels.
Jean-Yves Avenard [:jya]
Comment 4
2025-01-07 17:57:16 PST
This change is wrong. as written in
https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423
It breaks the spec. There's nothing in the spec that makes the play event being conditional of a seek having been completed.
https://html.spec.whatwg.org/multipage/media.html#internal-play-steps
if you call play() (even during a seek) and playback is allowed, the play event should be fired. Found be investigating why Duolingo was now broken in Safari STP 210.
Jean-Yves Avenard [:jya]
Comment 5
2025-01-07 18:17:05 PST
Reopened Bugzilla. Broke duolingo, calling play() during a seek() is allowed by the spec. And the play event should be fired even if the seek hasn't completed., tracking revert in
https://bugs.webkit.org/show_bug.cgi?id=285568
.
Enrique Ocaña
Comment 6
2025-02-13 09:31:35 PST
After analyzing the spec and discussing it with the original
https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423
reporter, we've concluded that the revert is fine and this bug should be resolved as invalid, since it's against the spec. Thanks for having taken the effort to prove your point, Jean-Yves.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug