RESOLVED FIXED 27918
commit-queue mode for bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=27918
Summary commit-queue mode for bugzilla-tool
Adam Barth
Reported 2009-07-31 23:00:19 PDT
We should be able to run bugzilla-tool in a commit-queue mode that recovers from errors gracefully. I have a wrapper script that knows how to restart bugzilla-tool when it errors out.
Attachments
commit-queue script (192 bytes, text/plain)
2009-07-31 23:01 PDT, Adam Barth
no flags
Work in progress (6.81 KB, patch)
2009-08-03 18:40 PDT, Adam Barth
no flags
Patch v1 (7.53 KB, patch)
2009-08-03 22:56 PDT, Adam Barth
eric: review+
Adam Barth
Comment 1 2009-07-31 23:01:17 PDT
Created attachment 33932 [details] commit-queue script Here's the script i'm using. Could probably use some iteration.
Adam Barth
Comment 2 2009-07-31 23:22:31 PDT
Sometimes patch requires user interaction. There doesn't to be an obvious flag that does what we want. --batch is close, but it will assume the patch is reversed if it appears that way, which is kind of like an automated rollout...
Adam Barth
Comment 3 2009-08-01 00:47:11 PDT
Also, failing tests pop up safari, which needs to be closed. The build bots must have a flag that suppresses this behavior. More investigation needed.
Adam Barth
Comment 4 2009-08-03 18:40:09 PDT
Created attachment 34032 [details] Work in progress
Adam Barth
Comment 5 2009-08-03 19:23:00 PDT
Comment on attachment 34032 [details] Work in progress Worked at least for a simple test case.
Eric Seidel (no email)
Comment 6 2009-08-03 19:40:29 PDT
Comment on attachment 34032 [details] Work in progress We could key this choice off of an option some day: 6 for bug_id in bug_ids: 147 print "%s" % tool.bugs.bug_url_for_bug_id(bug_id) 147 print "%s" % bug_id Danger Danger will robinson! 366 options.force_clean = True I don't think we should --force-clean automagically. Seems we should check the value of ['commit-queue'] here: 239 if 'commit-queue' in attachment and not attachment['is_obsolete']: attachment.get('commit-queue', False) might do the trick. I think ['commit-queue'] might throw an exception. Otherwise looks good. We need to fix the "destroying your current work state" problem by forcing --force-clean. We need to require something to be passed before we go destroying data. You should be aware of the proposed refactoring in: https://bugs.webkit.org/show_bug.cgi?id=26715 (I really should split out the refactoring bits into a separate patch and get it landed.)
Adam Barth
Comment 7 2009-08-03 22:56:11 PDT
Created attachment 34036 [details] Patch v1
Adam Barth
Comment 8 2009-08-04 00:04:53 PDT
Comment on attachment 34036 [details] Patch v1 Oops. Didn't mean to obsolete this patch.
Eric Seidel (no email)
Comment 9 2009-08-04 00:30:45 PDT
Comment on attachment 34036 [details] Patch v1 Seems you should combine this with teh one I just reviewed. No sense in adding the command only to remove it again. 217 attachment['commit-queue'] = True # FIXME: Validate that the flag was set by a committer. validation is possible as soon as bug 27972 is reviewed. Otherwise this looks great!
Adam Barth
Comment 10 2009-08-04 01:19:34 PDT
Committed revision 46751.
Note You need to log in before you can comment on or make changes to this bug.