Bug 27970 - bugzilla-tool --commit-queue should only land commit-queue+ patches
Summary: bugzilla-tool --commit-queue should only land commit-queue+ patches
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on: 27918
  Show dependency treegraph
Reported: 2009-08-04 00:01 PDT by Adam Barth
Modified: 2009-08-04 01:20 PDT (History)
1 user (show)

See Also:

Patch v1 (4.20 KB, patch)
2009-08-04 00:05 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-08-04 00:01:25 PDT
I don't think the land-commit-queue command makes sense.  It's more robust to drive the commit-queue from another process.  When we do that, we want to only commit patches that have the commit-queue+ flag, so we should make land-patches --commit-queue do the filtering.
Comment 1 Adam Barth 2009-08-04 00:02:25 PDT
This patch requires the infrastructure from Bug 27918.
Comment 2 Adam Barth 2009-08-04 00:05:30 PDT
Created attachment 34039 [details]
Patch v1
Comment 3 Eric Seidel (no email) 2009-08-04 00:27:36 PDT
Comment on attachment 34039 [details]
Patch v1

Yay minus lines!
Comment 4 Adam Barth 2009-08-04 01:20:07 PDT
Committed revision 46751.