RESOLVED FIXED 277057
Make writing-mode/direction/TextFlow conditional checks consistent, efficient, and correct 
https://bugs.webkit.org/show_bug.cgi?id=277057
Summary Make writing-mode/direction/TextFlow conditional checks consistent, efficient...
fantasai
Reported 2024-07-24 17:54:20 PDT
We currently have a ton of ad-hoc checks for writing-mode and direction in our codebase, each following their own pattern of boolean operators, temporary variables, and conditional statements. This makes the code harder to read, and more likely to contain errors. We should instead have RenderStyle return a WritingMode object (similar to Gecko's) that encapsulates all of the relevant CSS style information and that has convenience methods to easily, efficiently, and correctly return the specific resolved information that layout code tends to query.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-07-24 17:54:40 PDT
<rdar://problem/132446895>
fantasai
Comment 2 2024-08-11 22:49:12 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32026
EWS
Comment 3 2024-10-22 09:27:02 PDT
Committed 285555@main (72e07604aff9): <https://commits.webkit.org/285555@main> Reviewed commits have been landed. Closing PR #32026 and removing active labels.
Tim Nguyen (:ntim)
Comment 4 2024-10-22 09:27:52 PDT
*** Bug 276028 has been marked as a duplicate of this bug. ***
Tim Nguyen (:ntim)
Comment 5 2025-01-02 12:07:03 PST
*** Bug 260036 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.