Bug 276028 - Get rid of makeTextFlow constructor
Summary: Get rid of makeTextFlow constructor
Status: RESOLVED DUPLICATE of bug 277057
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on: 276138
Blocks:
  Show dependency tree / graph
 
Reported: 2024-06-28 21:24 PDT by Tim Nguyen (:ntim)
Modified: 2024-10-22 09:27 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2024-06-28 21:24:57 PDT 
The default TextFlow constructor should just be used. The sideways writing mode logic is incorrect in there.
Comment 1 Radar WebKit Bug Importer 2024-06-29 04:18:41 PDT 
<rdar://problem/130808015>
Comment 2 Tim Nguyen (:ntim) 2024-06-29 04:20:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30300
Comment 3 EWS 2024-06-29 09:49:36 PDT 
Committed 280500@main (e6d038446cca): <https://commits.webkit.org/280500@main>

Reviewed commits have been landed. Closing PR #30300 and removing active labels.
Comment 4 WebKit Commit Bot 2024-07-02 12:37:02 PDT 
Re-opened since this is blocked by bug 276138
Comment 5 Tim Nguyen (:ntim) 2024-10-22 09:27:52 PDT 

*** This bug has been marked as a duplicate of bug 277057 ***