Bug 269799 - Fill in/fix macros in WebKitTargetConditionals.xcconfig
Summary: Fill in/fix macros in WebKitTargetConditionals.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 244440 245692 250521 250612 252064 252066 252076 252970
Blocks:
  Show dependency tree / graph
 
Reported: 2024-02-20 10:54 PST by David Kilzer (:ddkilzer)
Modified: 2024-02-21 12:27 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2024-02-20 10:54:22 PST 
Fill in/fix macros in WebKitTargetConditionals.xcconfig.

Dan Bernstein's multi-version macOS macros were broken/missing over the past few years, so this bug is to track fixing those while adding support for the mysterious future.

Note that I removed the multi-version iOS macros in Bug 252076 since they weren't being used.

I'm also looking for suggestions on how many older builds for which to keep macros on each OS.
Comment 1 Radar WebKit Bug Importer 2024-02-20 10:56:00 PST 
<rdar://problem/123322741>
Comment 2 David Kilzer (:ddkilzer) 2024-02-20 11:16:48 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24827
Comment 3 EWS 2024-02-21 12:27:36 PST 
Committed 275122@main (637fd114532a): <https://commits.webkit.org/275122@main>

Reviewed commits have been landed. Closing PR #24827 and removing active labels.