RESOLVED FIXED 252064
Fix mistakes in WebKitTargetConditionals.xcconfig 
https://bugs.webkit.org/show_bug.cgi?id=252064
Summary Fix mistakes in WebKitTargetConditionals.xcconfig
David Kilzer (:ddkilzer)
Reported 2023-02-10 10:42:00 PST
Fix mistakes in WebKitTargetConditionals.xcconfig. The following macros are defined incorrectly (they result in circular definitions): ``` WK_IOS_17 = $(WK_IOS_17_$(WK_IOS_BEFORE_17)); WK_IOS_17_ = $(WK_IOS_17); // BUG: Circular definition. [...] WK_TVOS_16 = $(WK_TVOS_16_$(WK_TVOS_BEFORE_16)); WK_TVOS_16_ = $(WK_TVOS_16); // BUG: Circular definition. [...] WK_TVOS_17 = $(WK_TVOS_17_$(WK_TVOS_BEFORE_17)); WK_TVOS_17_ = $(WK_TVOS_17); // BUG: Circular definition. ``` The net effect of this error was that Bug 245692 had no effect on iOS builds because `WK_IOS_17` would never be defined as `_IOS_SINCE_17`: Enable libc++ assertions https://bugs.webkit.org/show_bug.cgi?id=245692 rdar://100416021 https://commits.webkit.org/259122@main
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-02-10 10:42:28 PST
<rdar://problem/105284669>
David Kilzer (:ddkilzer)
Comment 2 2023-02-10 10:52:47 PST
Pull request: https://github.com/WebKit/WebKit/pull/9936
EWS
Comment 3 2023-02-10 16:16:11 PST
Committed 260134@main (adf544afeb9f): <https://commits.webkit.org/260134@main> Reviewed commits have been landed. Closing PR #9936 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.