RESOLVED FIXED 252076
Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=252076
Summary Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig
David Kilzer (:ddkilzer)
Reported 2023-02-10 14:11:51 PST
Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig. They aren't used anywhere inside WebKit, and they haven't been kept up-to-date after `WK_IOS_17` was added, so they likely aren't used any longer. Referring to these Xcode variables in Configurations/WebKitTargetConditionals.xcconfig: ''' WK_IOS_13_14 = $(WK_IOS_13_14_$(WK_IOS_BEFORE_13)); WK_IOS_13_14_ = $(WK_IOS_14); WK_IOS_13_14_YES = _IOS_BEFORE_13; WK_IOS_13_15 = $(WK_IOS_13_15_$(WK_IOS_BEFORE_13)); WK_IOS_13_15_ = $(WK_IOS_15); WK_IOS_13_15_YES = _IOS_BEFORE_13; WK_IOS_13_16 = $(WK_IOS_13_16_$(WK_IOS_BEFORE_13)); WK_IOS_13_16_ = $(WK_IOS_16); WK_IOS_13_16_YES = _IOS_BEFORE_13; [...] WK_IOS_14_15 = $(WK_IOS_14_15_$(WK_IOS_BEFORE_14)); WK_IOS_14_15_ = $(WK_IOS_15); WK_IOS_14_15_YES = _IOS_BEFORE_14; WK_IOS_14_16 = $(WK_IOS_14_16_$(WK_IOS_BEFORE_14)); WK_IOS_14_16_ = $(WK_IOS_16); WK_IOS_14_16_YES = _IOS_BEFORE_14; [...] WK_IOS_15_16 = $(WK_IOS_15_16_$(WK_IOS_BEFORE_15)); WK_IOS_15_16_ = $(WK_IOS_16); WK_IOS_15_16_YES = _IOS_BEFORE_15; [...] WK_IOS_16_17 = $(WK_IOS_16_17_$(WK_IOS_BEFORE_16)); WK_IOS_16_17_ = $(WK_IOS_17); WK_IOS_16_17_YES = _IOS_BEFORE_16; '''
Attachments
Radar WebKit Bug Importer
Comment 1 2023-02-10 14:12:12 PST
David Kilzer (:ddkilzer)
Comment 2 2023-02-10 14:14:35 PST
BTW, the existence of these variables may have lead to this apparent copy-paste mistake: Fix mistakes in WebKitTargetConditionals.xcconfig https://bugs.webkit.org/show_bug.cgi?id=252064
David Kilzer (:ddkilzer)
Comment 3 2023-02-10 14:16:37 PST
EWS
Comment 4 2023-02-18 09:57:45 PST
Committed 260514@main (093c15d17e01): <https://commits.webkit.org/260514@main> Reviewed commits have been landed. Closing PR #9947 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.