WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26549
Web Inspector needs a testing infrastructure
https://bugs.webkit.org/show_bug.cgi?id=26549
Summary
Web Inspector needs a testing infrastructure
Kevin McCullough
Reported
2009-06-19 11:08:00 PDT
* SUMMARY We have many involved and highly promoted features in the Web Inspector but with almost no way to test most of them. (e.g. the JS debugger and profiler) We should build a testing infrastructure similar to DRT that allows the Inspector to be tested with simple JS and HTML files so that developers can create tests like the LayoutTests, and make them easy to run by developers and the build bots.
Attachments
testing harness
(19.61 KB, patch)
2009-09-30 07:45 PDT
,
Pavel Feldman
timothy
: review-
Details
Formatted Diff
Diff
testing harness #2
(47.77 KB, patch)
2009-10-01 12:48 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
testing harness #2 with waitToDumpWatchdogInterval rolled back to original value
(47.40 KB, patch)
2009-10-01 12:52 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2009-06-19 13:58:53 PDT
<
rdar://problem/6988926
>
Pavel Feldman
Comment 2
2009-09-30 07:45:26 PDT
Created
attachment 40370
[details]
testing harness This patch contains two test cases and the harness implementation for the Mac. I'd like to get your feedback on it before I extract WebInspectorPrivate.h and jump into implementing it for other platforms.
Timothy Hatcher
Comment 3
2009-10-01 07:47:50 PDT
Comment on
attachment 40370
[details]
testing harness Some tabs in evaluate-in-frontend.js.
> + var output = document.getElementById("output"); > + output.innerHTML += text + "<BR>";
Stray space.
> + void testEvaluateInFrontend(long callId, const String& script);
These functions with "testEvaluate" read funny. I think "evaluateTest" would read better. Since I read it as "evaluate this test", not "test the evaluate".
> + Vector<pair<long, String> > m_pendingTestEvaluateInFrontendCommands;
Maybe m_pendingEvaluateTestCommands.
Pavel Feldman
Comment 4
2009-10-01 12:48:37 PDT
Created
attachment 40470
[details]
testing harness #2
Pavel Feldman
Comment 5
2009-10-01 12:52:04 PDT
Created
attachment 40472
[details]
testing harness #2 with waitToDumpWatchdogInterval rolled back to original value Note that this patch requires additional testing on non-Mac platforms prior to landing.
Pavel Feldman
Comment 6
2009-10-02 04:39:15 PDT
I am splitting this patch into several ones:
https://bugs.webkit.org/show_bug.cgi?id=30008
https://bugs.webkit.org/show_bug.cgi?id=30009
https://bugs.webkit.org/show_bug.cgi?id=30010
https://bugs.webkit.org/show_bug.cgi?id=30014
Timothy Hatcher
Comment 7
2009-10-02 11:12:05 PDT
Comment on
attachment 40472
[details]
testing harness #2 with waitToDumpWatchdogInterval rolled back to original value Clearing the review flag since this patch has been split.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug