In order to run batch web inspector layout tests (and not affect subsequent tests) we should close inspector client's view upon InspectorController::close API call.
Created attachment 40508 [details] patch
Comment on attachment 40508 [details] patch > Page* WebInspectorClient::createPage() > { > - if (m_webView) > - return core(m_webView.get()); > - > ASSERT(!m_hwnd); > > registerWindowClass(); That !m_hwnd ASSERT will fire the second time.
Created attachment 40580 [details] patch with comments addressed I still need to test it on non-Mac platforms manually.
Comment on attachment 40580 [details] patch with comments addressed I think you will need: if (m_hwnd) ::DestroyWindow(m_hwnd); Also: if (inspectorView) delete inspectorView;
Created attachment 40631 [details] patch Done destroying the window. Why do you think delete inspectorView is necessary? (I don't find this code in the destructor...)
(In reply to comment #5) > Created an attachment (id=40631) [details] > patch > > Done destroying the window. Why do you think delete inspectorView is necessary? > (I don't find this code in the destructor...) I missed the fact that it uses a spart pointer.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebKit/gtk/ChangeLog M WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebInspectorClient.mm M WebKit/qt/ChangeLog M WebKit/qt/WebCoreSupport/InspectorClientQt.cpp M WebKit/win/ChangeLog M WebKit/win/WebCoreSupport/WebInspectorClient.cpp Committed r49190