RESOLVED FIXED 30009
Web Inspector: close inspector client view on InspectorController::close API call.
https://bugs.webkit.org/show_bug.cgi?id=30009
Summary Web Inspector: close inspector client view on InspectorController::close API ...
Pavel Feldman
Reported 2009-10-02 02:23:42 PDT
In order to run batch web inspector layout tests (and not affect subsequent tests) we should close inspector client's view upon InspectorController::close API call.
Attachments
patch (7.49 KB, patch)
2009-10-02 04:32 PDT, Pavel Feldman
timothy: review-
patch with comments addressed (7.42 KB, patch)
2009-10-03 11:44 PDT, Pavel Feldman
timothy: review-
patch (7.52 KB, patch)
2009-10-05 07:16 PDT, Pavel Feldman
timothy: review+
Pavel Feldman
Comment 1 2009-10-02 04:32:03 PDT
Timothy Hatcher
Comment 2 2009-10-02 11:08:59 PDT
Comment on attachment 40508 [details] patch > Page* WebInspectorClient::createPage() > { > - if (m_webView) > - return core(m_webView.get()); > - > ASSERT(!m_hwnd); > > registerWindowClass(); That !m_hwnd ASSERT will fire the second time.
Pavel Feldman
Comment 3 2009-10-03 11:44:35 PDT
Created attachment 40580 [details] patch with comments addressed I still need to test it on non-Mac platforms manually.
Timothy Hatcher
Comment 4 2009-10-03 16:10:24 PDT
Comment on attachment 40580 [details] patch with comments addressed I think you will need: if (m_hwnd) ::DestroyWindow(m_hwnd); Also: if (inspectorView) delete inspectorView;
Pavel Feldman
Comment 5 2009-10-05 07:16:30 PDT
Created attachment 40631 [details] patch Done destroying the window. Why do you think delete inspectorView is necessary? (I don't find this code in the destructor...)
Timothy Hatcher
Comment 6 2009-10-05 09:09:19 PDT
(In reply to comment #5) > Created an attachment (id=40631) [details] > patch > > Done destroying the window. Why do you think delete inspectorView is necessary? > (I don't find this code in the destructor...) I missed the fact that it uses a spart pointer.
Pavel Feldman
Comment 7 2009-10-06 08:49:08 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebKit/gtk/ChangeLog M WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebInspectorClient.mm M WebKit/qt/ChangeLog M WebKit/qt/WebCoreSupport/InspectorClientQt.cpp M WebKit/win/ChangeLog M WebKit/win/WebCoreSupport/WebInspectorClient.cpp Committed r49190
Note You need to log in before you can comment on or make changes to this bug.