Bug 30014 – Web Inspector: add initial layout tests for web inspector.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Add initial tests for the framework itself, elements panel and console.

[Pavel Feldman]

Created attachment 40510 [details]
patch

[Timothy Hatcher]

Comment on attachment 40510 [details]
patch

It looks like LayoutTests/inspector/elements-panel-structure-expected.txt has funny line endings.

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 40510 [details])
> It looks like LayoutTests/inspector/elements-panel-structure-expected.txt has
> funny line endings.

These are 'ZERO WIDTH SPACE' (U+200B) characters that are returned as a part of textContent. Anyway, replacing them with "" to avoid confusion in my next patch.

[Pavel Feldman]

Created attachment 40579 [details]
patch with comments addressed

[Timothy Hatcher]

Comment on attachment 40579 [details]
patch with comments addressed

Hmm I wonder why it had zero-width spaces…

[Pavel Feldman]

(In reply to comment #5)
> (From update of attachment 40579 [details])
> Hmm I wonder why it had zero-width spaces…

utilities.js, function nodeTitleInfo, search for "&#8203".

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/inspector/console-tests-expected.txt
	A	LayoutTests/inspector/console-tests.html
	A	LayoutTests/inspector/elements-panel-structure-expected.txt
	A	LayoutTests/inspector/elements-panel-structure.html
	A	LayoutTests/inspector/evaluate-in-frontend-expected.txt
	A	LayoutTests/inspector/evaluate-in-frontend.html
	A	LayoutTests/inspector/evaluate-in-frontend.js
Committed r49499

[Pavel Feldman]

Needed to revert since tests were failing on bots. Will look into the reasons...

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	LayoutTests/inspector/console-tests-expected.txt
	D	LayoutTests/inspector/console-tests.html
	D	LayoutTests/inspector/elements-panel-structure-expected.txt
	D	LayoutTests/inspector/elements-panel-structure.html
	D	LayoutTests/inspector/evaluate-in-frontend-expected.txt
	D	LayoutTests/inspector/evaluate-in-frontend.html
	D	LayoutTests/inspector/evaluate-in-frontend.js
	M	LayoutTests/ChangeLog
Committed r49500

[Pavel Feldman]

Created attachment 41167 [details]
skip patch

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/gtk/Skipped
	M	LayoutTests/platform/mac-leopard/Skipped
	M	LayoutTests/platform/mac-snowleopard/Skipped
	M	LayoutTests/platform/mac-tiger/Skipped
	M	LayoutTests/platform/mac/Skipped
	M	LayoutTests/platform/qt/Skipped
	M	LayoutTests/platform/win/Skipped
Committed r49573

[Pavel Feldman]

Created attachment 41178 [details]
[PATCH] Enable developers extras in inspector tests

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
	M	WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
Committed r49613

[Pavel Feldman]

Created attachment 41216 [details]
[PATCH] Enable tests (remove from skipped)

[Timothy Hatcher]

Comment on attachment 41216 [details]
[PATCH] Enable tests (remove from skipped)

> +            // layoutTestController.showWebInspector();

Should this be uncommented or removed?

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/elements-panel-structure-expected.txt
	M	LayoutTests/inspector/elements-panel-structure.html
	M	LayoutTests/inspector/evaluate-in-frontend.js
	M	LayoutTests/platform/mac-leopard/Skipped
	M	LayoutTests/platform/mac-snowleopard/Skipped
	M	LayoutTests/platform/mac-tiger/Skipped
	M	LayoutTests/platform/mac/Skipped
	M	LayoutTests/platform/win/Skipped
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
Committed r49629