30014 – Web Inspector: add initial layout tests for web inspector.

Bug 30014 - Web Inspector: add initial layout tests for web inspector.

Summary: Web Inspector: add initial layout tests for web inspector.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (Deprecated) (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Pavel Feldman

URL:
Keywords:

Depends on:
Blocks:	26549
	Show dependency tree / graph

Reported:	2009-10-02 04:25 PDT by Pavel Feldman
Modified:	2009-10-15 09:21 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
patch (9.57 KB, patch) 2009-10-02 04:33 PDT, Pavel Feldman	timothy: review-	Details \| Formatted Diff \| Diff
patch with comments addressed (9.57 KB, patch) 2009-10-03 11:40 PDT, Pavel Feldman	timothy: review+	Details \| Formatted Diff \| Diff
skip patch (4.91 KB, patch) 2009-10-14 10:26 PDT, Pavel Feldman	no flags	Details \| Formatted Diff \| Diff
[PATCH] Enable developers extras in inspector tests (3.03 KB, patch) 2009-10-14 12:24 PDT, Pavel Feldman	no flags	Details \| Formatted Diff \| Diff
[PATCH] Enable tests (remove from skipped) (8.94 KB, patch) 2009-10-15 04:51 PDT, Pavel Feldman	timothy: review+	Details \| Formatted Diff \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pavel Feldman 2009-10-02 04:25:43 PDT

Add initial tests for the framework itself, elements panel and console.

Comment 1 Pavel Feldman 2009-10-02 04:33:57 PDT

Created attachment 40510 [details]
patch

Comment 2 Timothy Hatcher 2009-10-02 11:13:23 PDT

Comment on attachment 40510 [details]
patch

It looks like LayoutTests/inspector/elements-panel-structure-expected.txt has funny line endings.

Comment 3 Pavel Feldman 2009-10-03 11:39:51 PDT

(In reply to comment #2)
> (From update of attachment 40510 [details])
> It looks like LayoutTests/inspector/elements-panel-structure-expected.txt has
> funny line endings.

These are 'ZERO WIDTH SPACE' (U+200B) characters that are returned as a part of textContent. Anyway, replacing them with "" to avoid confusion in my next patch.

Comment 4 Pavel Feldman 2009-10-03 11:40:55 PDT

Created attachment 40579 [details]
patch with comments addressed

Comment 5 Timothy Hatcher 2009-10-03 16:07:36 PDT

Comment on attachment 40579 [details]
patch with comments addressed

Hmm I wonder why it had zero-width spaces…

Comment 6 Pavel Feldman 2009-10-04 02:41:00 PDT

(In reply to comment #5)
> (From update of attachment 40579 [details])
> Hmm I wonder why it had zero-width spaces…

utilities.js, function nodeTitleInfo, search for "&#8203".

Comment 7 Pavel Feldman 2009-10-13 04:54:03 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/inspector/console-tests-expected.txt
	A	LayoutTests/inspector/console-tests.html
	A	LayoutTests/inspector/elements-panel-structure-expected.txt
	A	LayoutTests/inspector/elements-panel-structure.html
	A	LayoutTests/inspector/evaluate-in-frontend-expected.txt
	A	LayoutTests/inspector/evaluate-in-frontend.html
	A	LayoutTests/inspector/evaluate-in-frontend.js
Committed r49499

Comment 8 Pavel Feldman 2009-10-13 05:15:47 PDT

Needed to revert since tests were failing on bots. Will look into the reasons...

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	LayoutTests/inspector/console-tests-expected.txt
	D	LayoutTests/inspector/console-tests.html
	D	LayoutTests/inspector/elements-panel-structure-expected.txt
	D	LayoutTests/inspector/elements-panel-structure.html
	D	LayoutTests/inspector/evaluate-in-frontend-expected.txt
	D	LayoutTests/inspector/evaluate-in-frontend.html
	D	LayoutTests/inspector/evaluate-in-frontend.js
	M	LayoutTests/ChangeLog
Committed r49500

Comment 9 Pavel Feldman 2009-10-14 10:26:19 PDT

Created attachment 41167 [details]
skip patch

Comment 10 Pavel Feldman 2009-10-14 10:35:23 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/gtk/Skipped
	M	LayoutTests/platform/mac-leopard/Skipped
	M	LayoutTests/platform/mac-snowleopard/Skipped
	M	LayoutTests/platform/mac-tiger/Skipped
	M	LayoutTests/platform/mac/Skipped
	M	LayoutTests/platform/qt/Skipped
	M	LayoutTests/platform/win/Skipped
Committed r49573

Comment 11 Pavel Feldman 2009-10-14 12:24:15 PDT

Created attachment 41178 [details]
[PATCH] Enable developers extras in inspector tests

Comment 12 Pavel Feldman 2009-10-15 01:56:40 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
	M	WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
Committed r49613

Comment 13 Pavel Feldman 2009-10-15 04:51:36 PDT

Created attachment 41216 [details]
[PATCH] Enable tests (remove from skipped)

Comment 14 Timothy Hatcher 2009-10-15 06:56:15 PDT

Comment on attachment 41216 [details]
[PATCH] Enable tests (remove from skipped)

> +            // layoutTestController.showWebInspector();

Should this be uncommented or removed?

Comment 15 Pavel Feldman 2009-10-15 09:21:37 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/elements-panel-structure-expected.txt
	M	LayoutTests/inspector/elements-panel-structure.html
	M	LayoutTests/inspector/evaluate-in-frontend.js
	M	LayoutTests/platform/mac-leopard/Skipped
	M	LayoutTests/platform/mac-snowleopard/Skipped
	M	LayoutTests/platform/mac-tiger/Skipped
	M	LayoutTests/platform/mac/Skipped
	M	LayoutTests/platform/win/Skipped
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
Committed r49629