Bug 265363 - Decouple BitmapImage sources and main functions into separate classes
Summary: Decouple BitmapImage sources and main functions into separate classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
: 268184 (view as bug list)
Depends on: 268127 267254 267570 267571 267607 268184 269626 271977
Blocks:
  Show dependency tree / graph
 
Reported: 2023-11-26 22:41 PST by Said Abou-Hallawa
Modified: 2024-04-01 12:18 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-11-26 22:41:54 PST 
This class is needlessly complicated which makes it difficult to hack. It handles

1. NativeImage and ImageSource images
2. Static and animated images
3. Async and sync image decoding

It also supports lots of testing APIs and tuning and corner cases. What we need is a simple and clear design interface which splits these cases and tuning nicely. This will make changing the class a lot easier in the future.
Comment 1 Radar WebKit Bug Importer 2023-11-26 22:42:32 PST 
<rdar://problem/118819338>
Comment 2 Said Abou-Hallawa 2023-11-26 22:48:59 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20916
Comment 3 EWS 2024-02-15 11:04:09 PST 
Committed 274746@main (055031e5c8a8): <https://commits.webkit.org/274746@main>

Reviewed commits have been landed. Closing PR #20916 and removing active labels.
Comment 4 WebKit Commit Bot 2024-02-16 16:21:14 PST 
Re-opened since this is blocked by bug 269626
Comment 5 Said Abou-Hallawa 2024-02-16 21:49:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24678
Comment 6 EWS 2024-03-29 06:50:53 PDT 
Committed 276827@main (8b78e07f7be5): <https://commits.webkit.org/276827@main>

Reviewed commits have been landed. Closing PR #24678 and removing active labels.
Comment 7 Said Abou-Hallawa 2024-04-01 12:17:14 PDT 
*** Bug 268184 has been marked as a duplicate of this bug. ***