WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
267607
Remove BitmapImage::updateFromSettings()
https://bugs.webkit.org/show_bug.cgi?id=267607
Summary
Remove BitmapImage::updateFromSettings()
Said Abou-Hallawa
Reported
2024-01-16 14:27:00 PST
This is an awkward interface to pass some painting options to BitmapImage::draw(). ImagePaintingOptions has been used for this purpose but BitmapImage::updateFromSettings() is used to pass some other options. But in reality all options can be passed through ImagePaintingOptions. With little care things can be restored after removing this method.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-01-16 14:27:53 PST
<
rdar://problem/121077174
>
Said Abou-Hallawa
Comment 2
2024-01-16 17:45:26 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22844
EWS
Comment 3
2024-01-25 12:16:19 PST
Committed
273528@main
(0c6288be7ffe): <
https://commits.webkit.org/273528@main
> Reviewed commits have been landed. Closing PR #22844 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug