Bug 267607 - Remove BitmapImage::updateFromSettings()
Summary: Remove BitmapImage::updateFromSettings()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 265363
  Show dependency tree / graph
 
Reported: 2024-01-16 14:27 PST by Said Abou-Hallawa
Modified: 2024-01-25 12:16 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2024-01-16 14:27:00 PST 
This is an awkward interface to pass some painting options to BitmapImage::draw(). ImagePaintingOptions has been used for this purpose but BitmapImage::updateFromSettings() is used to pass some other options. But in reality all options can be passed through ImagePaintingOptions. With little care things can be restored after removing this method.
Comment 1 Radar WebKit Bug Importer 2024-01-16 14:27:53 PST 
<rdar://problem/121077174>
Comment 2 Said Abou-Hallawa 2024-01-16 17:45:26 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22844
Comment 3 EWS 2024-01-25 12:16:19 PST 
Committed 273528@main (0c6288be7ffe): <https://commits.webkit.org/273528@main>

Reviewed commits have been landed. Closing PR #22844 and removing active labels.