Bug 267254 - Move BitmapImage format conversion to a new class name ImageAdapter
Summary: Move BitmapImage format conversion to a new class name ImageAdapter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 265363
  Show dependency tree / graph
 
Reported: 2024-01-08 21:56 PST by Said Abou-Hallawa
Modified: 2024-01-30 11:15 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2024-01-08 21:56:50 PST 
The classes Image and BitmapImage are overloaded with many other functions. The platform-specific format conversion is not tied to BitmapImage or Image. It relies mostly on NativeImages. So move the format conversion to a new class named ImageAdapter. Move also BitmapImage::nativeImageOfSize() and BitmapImage::framesNativeImages() to this new class since they are only used by the format conversion.
Comment 1 Radar WebKit Bug Importer 2024-01-08 21:57:57 PST 
<rdar://problem/120690546>
Comment 2 Said Abou-Hallawa 2024-01-08 22:39:05 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22535
Comment 3 EWS 2024-01-30 11:15:42 PST 
Committed 273772@main (ab92c87e9f99): <https://commits.webkit.org/273772@main>

Reviewed commits have been landed. Closing PR #22535 and removing active labels.